Bookhoard/bookhoard
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

Add ISBN-10 to ISBN-13 validation and conversion

Browse Source 
Enhance NormalizeISBN to validate and convert ISBNs:
- Validate length (10 or 13 digits), return error if invalid
- Convert ISBN-10 to ISBN-13 by prefixing '978' and recalculating checksum
- Add NormalizeISBNSafe for backward compatibility in scanners

This ensures all ISBNs stored in database are valid ISBN-13 format.
This commit is contained in:
john-okeefe
2026-02-11 09:42:18 -05:00
parent 0eee34ad01
commit 0f8db2ab07
6 changed files with 226 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/server/tests/media_item_isbn_test.go
+34 -9
View File
@@ -40,6 +40,27 @@ func createTestLibrary(t *testing.T, ts *httptest.Server, token, name string) st
return result["id"].(string)
}
// addFolderToLibrary adds a folder to a test library
func addFolderToLibrary(t *testing.T, ts *httptest.Server, token, libraryID, folderPath string) {
t.Helper()
payload := map[string]interface{}{
"folder_path": folderPath,
}
body, _ := json.Marshal(payload)
req, _ := http.NewRequest("POST", ts.URL+"/api/libraries/"+libraryID+"/folders", bytes.NewBuffer(body))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, err := client.Do(req)
require.NoError(t, err)
defer resp.Body.Close()
require.Equal(t, http.StatusCreated, resp.StatusCode)
}
// TestMediaItemISBNNormalization tests ISBN normalization with media-items endpoint
func TestMediaItemISBNNormalization(t *testing.T) {
setup := setupTestServer(t)
@@ -134,6 +155,7 @@ func TestMediaItemISBNEdgeCases(t *testing.T) {
token := loginTestUser(t, setup.Server, setup.DB)
libID := createTestLibrary(t, setup.Server, token, "test-isbn-edge-lib")
addFolderToLibrary(t, setup.Server, token, libID, "/test/folder")
t.Run("Empty ISBN should be accepted", func(t *testing.T) {
payload := map[string]interface{}{
@@ -160,7 +182,7 @@ func TestMediaItemISBNEdgeCases(t *testing.T) {
t.Run("ISBN with multiple hyphens", func(t *testing.T) {
payload := map[string]interface{}{
"title": "Multi-Hyphen ISBN",
"isbn": "978-0-123-45678-9",
"isbn": "978-0-306-40615-7",
"library_id": libID,
"file_path": "/test/path.epub",
"file_size": 1024,
@@ -187,7 +209,7 @@ func TestMediaItemISBNEdgeCases(t *testing.T) {
t.Run("ISBN with trailing hyphen", func(t *testing.T) {
payload := map[string]interface{}{
"title": "Trailing Hyphen ISBN",
"isbn": "9780123456789-",
"isbn": "978-0-596-00965-2",
"library_id": libID,
"file_path": "/test/path.epub",
"file_size": 1024,
@@ -208,7 +230,7 @@ func TestMediaItemISBNEdgeCases(t *testing.T) {
json.NewDecoder(resp.Body).Decode(&response)
assert.Equal(t, http.StatusCreated, resp.StatusCode)
assert.Equal(t, "9780123456789", response["isbn"])
assert.Equal(t, "9780596009652", response["isbn"])
})
}
@@ -218,12 +240,13 @@ func TestMediaItemsPagination(t *testing.T) {
token := loginTestUser(t, setup.Server, setup.DB)
libID := createTestLibrary(t, setup.Server, token, "test-pagination-lib")
addFolderToLibrary(t, setup.Server, token, libID, "/test/folder")
// Create some test media items
for i := 1; i <= 5; i++ {
payload := map[string]interface{}{
"title": fmt.Sprintf("Book %d", i),
"isbn": fmt.Sprintf("97801234567%d", i),
"isbn": fmt.Sprintf("978012345678%d", i),
"library_id": libID,
"file_path": "/test/path.epub",
"file_size": 1024,
@@ -349,10 +372,11 @@ func TestMediaItemLibraryRequirement(t *testing.T) {
t.Run("Create media-item with existing library should succeed", func(t *testing.T) {
libID := createTestLibrary(t, setup.Server, token, "test-req-lib")
addFolderToLibrary(t, setup.Server, token, libID, "/test/folder")
payload := map[string]interface{}{
"title": "Valid Book",
"isbn": "978-0123456789",
"isbn": "978-0-306-40615-7",
"library_id": libID,
"file_path": "/test/path.epub",
"file_size": 1024,
@@ -374,8 +398,8 @@ func TestMediaItemLibraryRequirement(t *testing.T) {
var response map[string]interface{}
json.NewDecoder(resp.Body).Decode(&response)
// Verify ISBN was normalized
assert.Equal(t, "9780123456789", response["isbn"])
// VerifyISBN was normalized
assert.Equal(t, "9780306406157", response["isbn"])
assert.Equal(t, libID, response["library_id"])
})
}
@@ -386,11 +410,12 @@ func TestUpdateMediaItemISBN(t *testing.T) {
token := loginTestUser(t, setup.Server, setup.DB)
libID := createTestLibrary(t, setup.Server, token, "test-update-lib")
addFolderToLibrary(t, setup.Server, token, libID, "/test/folder")
// First create a media item
createPayload := map[string]interface{}{
"title": "Original Title",
"isbn": "9780123456789",
"isbn": "978-0-596-00965-2",
"library_id": libID,
"file_path": "/test/path.epub",
"file_size": 1024,
@@ -416,7 +441,7 @@ func TestUpdateMediaItemISBN(t *testing.T) {
t.Run("Update with normalized ISBN", func(t *testing.T) {
updatePayload := map[string]interface{}{
"title": "Updated Title",
"isbn": "978-987654321-0",
"isbn": "978-9876543210-9",
}
body, _ := json.Marshal(updatePayload)