Bookhoard/bookhoard
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

test(system-settings): update tests for scan_poll_interval_seconds

Browse Source 
- Update validation to use scan_poll_interval_seconds field (1-3600 seconds)
- Update all test cases and assertions to use new field name
- Update integration test to reflect new field name
This commit is contained in:
john-okeefe
2026-02-28 12:57:34 -05:00
parent 5a2e1fda65
commit 1242550892
2 changed files with 38 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/handlers/system_settings.go
+17 -17
View File
@@ -20,14 +20,14 @@ func NewSystemSettingsHandler(db *database.Queries) *SystemSettingsHandler {
}
type UpdateScanSettingsRequest struct {
ScanFrequencyMinutes int32 `json:"scan_frequency_minutes" validate:"required,min=15,max=1440"`
AutoScanEnabled bool `json:"auto_scan_enabled"`
ScanPollIntervalSeconds int32 `json:"scan_poll_interval_seconds" validate:"required,min=1,max=3600"`
AutoScanEnabled bool `json:"auto_scan_enabled"`
}
type ScanSettingsResponse struct {
ScanFrequencyMinutes int32 `json:"scan_frequency_minutes"`
AutoScanEnabled bool `json:"auto_scan_enabled"`
Message string `json:"message,omitempty"`
ScanPollIntervalSeconds int32 `json:"scan_poll_interval_seconds"`
AutoScanEnabled bool `json:"auto_scan_enabled"`
Message string `json:"message,omitempty"`
}
func (h *SystemSettingsHandler) UpdateScanSettings(c echo.Context) error {
@@ -39,11 +39,11 @@ func (h *SystemSettingsHandler) UpdateScanSettings(c echo.Context) error {
return c.JSON(http.StatusBadRequest, map[string]string{"error": err.Error()})
}
scanFrequencyValue := strconv.FormatInt(int64(req.ScanFrequencyMinutes), 10)
scanFrequencyValue := strconv.FormatInt(int64(req.ScanPollIntervalSeconds), 10)
autoScanValue := strconv.FormatBool(req.AutoScanEnabled)
err := h.db.UpdateSystemSetting(c.Request().Context(), database.UpdateSystemSettingParams{
SettingKey: "scan_frequency_minutes",
SettingKey: "scan_poll_interval_seconds",
SettingValue: scanFrequencyValue,
})
if err != nil {
@@ -65,19 +65,19 @@ func (h *SystemSettingsHandler) UpdateScanSettings(c echo.Context) error {
}
return c.JSON(http.StatusOK, ScanSettingsResponse{
ScanFrequencyMinutes: req.ScanFrequencyMinutes,
AutoScanEnabled: req.AutoScanEnabled,
Message: "scan settings updated successfully",
ScanPollIntervalSeconds: req.ScanPollIntervalSeconds,
AutoScanEnabled: req.AutoScanEnabled,
Message: "scan settings updated successfully",
})
}
func (h *SystemSettingsHandler) GetScanSettings(c echo.Context) error {
scanFrequencySetting, err := h.db.GetSystemSetting(c.Request().Context(), "scan_frequency_minutes")
scanFrequencySetting, err := h.db.GetSystemSetting(c.Request().Context(), "scan_poll_interval_seconds")
if err != nil {
if err == pgx.ErrNoRows {
return c.JSON(http.StatusOK, ScanSettingsResponse{
ScanFrequencyMinutes: 60,
AutoScanEnabled: true,
ScanPollIntervalSeconds: 60,
AutoScanEnabled: true,
})
}
return c.JSON(http.StatusInternalServerError, map[string]string{"error": err.Error()})
@@ -87,8 +87,8 @@ func (h *SystemSettingsHandler) GetScanSettings(c echo.Context) error {
if err != nil {
if err == pgx.ErrNoRows {
return c.JSON(http.StatusOK, ScanSettingsResponse{
ScanFrequencyMinutes: 60,
AutoScanEnabled: true,
ScanPollIntervalSeconds: 60,
AutoScanEnabled: true,
})
}
return c.JSON(http.StatusInternalServerError, map[string]string{"error": err.Error()})
@@ -105,7 +105,7 @@ func (h *SystemSettingsHandler) GetScanSettings(c echo.Context) error {
}
return c.JSON(http.StatusOK, ScanSettingsResponse{
ScanFrequencyMinutes: int32(scanFrequency),
AutoScanEnabled: autoScanEnabled,
ScanPollIntervalSeconds: int32(scanFrequency),
AutoScanEnabled: autoScanEnabled,
})
}