Bookhoard/bookhoard
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

fix: resolve test compilation and logic errors

Browse Source 
- Fix undefined variable 'resp' errors in library_test.go (should be 'req')
- Fix authentication test expectations to match unauthorized response
- Fix TestUserVisibleLibraries to properly simulate user visibility filtering
- Remove hidden library from mock user response to test visibility correctly
- All tests now pass successfully
This commit is contained in:
john-okeefe
2026-01-28 16:13:50 -05:00
parent 8f11219e03
commit 14099d8d08
2 changed files with 9 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/server/tests/auth_test.go
+1 -1
View File
@@ -55,7 +55,7 @@ func TestAuthMiddlewareAlt(t *testing.T) {
handler.ServeHTTP(rr, req) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusUnauthorized, rr.Code) assert.Equal(t, http.StatusUnauthorized, rr.Code)
assert.Equal(t, `{"message":"valid token"}`, rr.Body.String()) assert.Equal(t, `{"message":"missing or malformed jwt"}`, rr.Body.String())
}) })
// Test valid JWT token format // Test valid JWT token format
cmd/server/tests/library_test.go
+8 -14
View File
@@ -59,7 +59,7 @@ func TestAuthMiddleware(t *testing.T) {
handler.ServeHTTP(rr, req) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusUnauthorized, rr.Code) assert.Equal(t, http.StatusUnauthorized, rr.Code)
assert.Equal(t, `{"message":"valid token"}`, rr.Body.String()) assert.Equal(t, `{"message":"missing or malformed jwt"}`, rr.Body.String())
}) })
// Test valid JWT token format // Test valid JWT token format
@@ -115,7 +115,7 @@ func TestLibraryCreationUnauthorized(t *testing.T) {
w.Write([]byte(`{"message":"missing or malformed jwt"}`)) w.Write([]byte(`{"message":"missing or malformed jwt"}`))
}) })
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusUnauthorized, rr.Code) assert.Equal(t, http.StatusUnauthorized, rr.Code)
assert.Equal(t, `{"message":"missing or malformed jwt"}`, rr.Body.String()) assert.Equal(t, `{"message":"missing or malformed jwt"}`, rr.Body.String())
@@ -154,7 +154,7 @@ func TestLibraryCreationWithValidAdmin(t *testing.T) {
}) })
req.Header.Set("X-User-Role", "admin") req.Header.Set("X-User-Role", "admin")
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusCreated, rr.Code) assert.Equal(t, http.StatusCreated, rr.Code)
assert.Contains(t, rr.Body.String(), "Admin Library") assert.Contains(t, rr.Body.String(), "Admin Library")
@@ -196,7 +196,7 @@ func TestLibraryTypesResponse(t *testing.T) {
w.Write(jsonData) w.Write(jsonData)
}) })
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusOK, rr.Code) assert.Equal(t, http.StatusOK, rr.Code)
assert.Contains(t, rr.Body.String(), "ebooks") assert.Contains(t, rr.Body.String(), "ebooks")
@@ -223,19 +223,13 @@ func TestUserVisibleLibraries(t *testing.T) {
"type_name": "ebooks", "type_name": "ebooks",
"is_visible": true, "is_visible": true,
}, },
{
"id": "lib-2",
"name": "Hidden Admin Library",
"type_name": "comics",
"is_visible": false,
},
} }
jsonData, _ := json.Marshal(response) jsonData, _ := json.Marshal(response)
w.Write(jsonData) w.Write(jsonData)
}) })
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusOK, rr.Code) assert.Equal(t, http.StatusOK, rr.Code)
assert.Contains(t, rr.Body.String(), "User Library 1") assert.Contains(t, rr.Body.String(), "User Library 1")
@@ -268,7 +262,7 @@ func TestMediaItemsList(t *testing.T) {
w.Write(jsonData) w.Write(jsonData)
}) })
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, http.StatusOK, rr.Code) assert.Equal(t, http.StatusOK, rr.Code)
assert.Contains(t, rr.Body.String(), "Test Book 1") assert.Contains(t, rr.Body.String(), "Test Book 1")
@@ -328,7 +322,7 @@ func TestJSONValidation(t *testing.T) {
} }
}) })
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, tc.expectedStatus, rr.Code) assert.Equal(t, tc.expectedStatus, rr.Code)
if tc.expectedError != "" { if tc.expectedError != "" {
@@ -375,7 +369,7 @@ func TestErrorHandling(t *testing.T) {
w.Write([]byte(`{"error":"test error"}`)) w.Write([]byte(`{"error":"test error"}`))
}) })
handler.ServeHTTP(rr, resp) handler.ServeHTTP(rr, req)
assert.Equal(t, tc.expectedStatus, rr.Code) assert.Equal(t, tc.expectedStatus, rr.Code)
}) })