Bookhoard/bookhoard
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

fix: Fix failing integration tests and update documentation

Browse Source 
- Fix TestUpdateDevice: Use correct JSON field name and handle float64 type
- Fix TestRejectDeviceRegistration: Expect message response instead of boolean
- Update approve device docs: Add missing response fields
- Update reject device docs: Correct message text and format
- Update Bruno API: Fix example response for reject endpoint

Both integration tests now pass while maintaining API consistency.
This commit is contained in:
john-okeefe
2026-02-10 10:22:19 -05:00
parent 1413c75b26
commit 2b24dd9dd3
4 changed files with 14 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bruno/devices/Reject Device Registration.bru
+6 -7
View File
@@ -33,11 +33,10 @@ docs {
- 404: Registration not found - 404: Registration not found
- 400: Invalid registration status - 400: Invalid registration status
**Example Response:** **Example Response:**
```json ```json
{ {
"message": "Device registration rejected", "message": "device registration rejected"
"registration_id": "uuid" }
} ```
```
} }
cmd/server/tests/device_test.go
+2 -2
View File
@@ -173,7 +173,7 @@ func TestUpdateDevice(t *testing.T) {
updatedDevice := response["device"].(map[string]interface{}) updatedDevice := response["device"].(map[string]interface{})
assert.Equal(t, "Updated Device Name", updatedDevice["device_name"], "Should have updated name") assert.Equal(t, "Updated Device Name", updatedDevice["device_name"], "Should have updated name")
assert.Equal(t, false, updatedDevice["sync_enabled"], "Should be disabled") assert.Equal(t, false, updatedDevice["sync_enabled"], "Should be disabled")
assert.Equal(t, int32(10), updatedDevice["sync_frequency"], "Should have updated frequency") assert.Equal(t, float64(10), updatedDevice["sync_frequency_minutes"], "Should have updated frequency")
} }
func TestDeleteDevice(t *testing.T) { func TestDeleteDevice(t *testing.T) {
@@ -325,5 +325,5 @@ func TestRejectDeviceRegistration(t *testing.T) {
var rejectResponse map[string]interface{} var rejectResponse map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &rejectResponse) json.Unmarshal(rec.Body.Bytes(), &rejectResponse)
assert.True(t, rejectResponse["rejected"].(bool), "Should confirm rejection") assert.Equal(t, "device registration rejected", rejectResponse["message"], "Should confirm rejection message")
} }
docs/developer/api/devices/approve_device_registration.md
+5 -2
View File
@@ -28,8 +28,11 @@ Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9...
```json ```json
{ {
"message": "Device registration approved", "message": "device approved successfully",
"device_id": "uuid" "device_name": "string",
"device_type": "string",
"registration_id": "uuid",
"approved": true
} }
``` ```
docs/developer/api/devices/reject_device_registration.md
+1 -1
View File
@@ -28,7 +28,7 @@ Authorization: Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9...
```json ```json
{ {
"message": "Device registration rejected" "message": "device registration rejected"
} }
``` ```