fix(podcasts+ui): user-test round 3 — five browser-reported defects
1. Add-modal 'Download order' never revealed: the CSS sibling selector
(#podcast-download-all:checked ~ .podcast-add-order) can't fire —
the checkbox was nested inside a wrapper div, so the select row was
no SIBLING of the input. Restructured: input, label, and order row
are now siblings under one flex-wrap wrapper.
2. Order + auto-download dropdowns always displayed the LAST option
('Newest first'/'Newest') regardless of the saved value: templ's
selected={ boolExpr } compiles to selected="false" — and the mere
PRESENCE of the attribute selects the option, so every option was
selected and the browser honored the last. Sweep to the boolean-
attribute form selected?={...} (omits on false) across
podcast_detail (14), book_detail_modals (10: manga type/reading
direction selects + abridged/explicit checkboxes — same defect,
always-checked), collection_modal (2: hide-finished/show-up-next
always-checked). Values were SAVING correctly all along; this was
pure display. audio_reader/collections :selected/:checked are
Alpine bindings — unaffected.
3. Remove Feed (and every hx-confirm) still showed the browser dialog
for signed-in users: the global confirm modal rendered at the end
of SidebarSignIn — signed-IN pages have no SidebarSignIn, so no
#confirm-modal existed and confirmDialog() degraded to
window.confirm. Moved the modal into Header proper (rendered on
every page, after </aside>).
4. Facet bar at scale: values now carry feed COUNTS, sort by frequency
DESC then alphabetically, cap at 6 chips per group flat, and the
rest collapse into a native <details> '+N more' expander — hundreds
of hosts/tags degrade gracefully instead of a wall of chips.
Verified live on the dev instance (order select reflects the saved
override, override row persists, reveal fires, modal renders on
signed-in pages). Podcast + logout + media-pin suites green; vitest
167 green.
This commit is contained in:
1 parent
15f41e6fd4
commit
2fd0828c06
13 files changed
+1004
-948
No files matched your search
+22
-20
@@ -225,6 +225,28 @@ templ Header(user User, currentPath string) {
|
||||
}
|
||||
</div>
|
||||
</aside>
|
||||
<!-- Global confirm modal (issue #5): ONE styled dialog answers every
|
||||
hx-confirm sitewide via the htmx:confirm interceptor in
|
||||
web/src/confirm.ts, and exposes the confirmDialog() promise for
|
||||
legacy JS call sites. Inert until shown. MUST render on every
|
||||
page (it previously lived inside SidebarSignIn — signed-in
|
||||
pages had no #confirm-modal, so confirmDialog degraded to the
|
||||
native window.confirm; fixed 2026-10-30, user report). -->
|
||||
<div
|
||||
id="confirm-modal"
|
||||
class="hidden fixed inset-0 z-[60] flex items-center justify-center p-4"
|
||||
style="background-color: var(--surface-overlay);"
|
||||
>
|
||||
<div class="card w-full max-w-sm" style="box-shadow: var(--shadow-pop);">
|
||||
<div class="p-5 border-b" style="border-color: var(--border);">
|
||||
<p id="confirm-modal-message" class="text-sm font-medium" style="color: var(--text-primary)"></p>
|
||||
</div>
|
||||
<div class="p-4 flex justify-end gap-2">
|
||||
<button id="confirm-modal-cancel" class="btn btn-secondary">Cancel</button>
|
||||
<button id="confirm-modal-accept" class="btn btn-primary">Confirm</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
<!-- Topbar -->
|
||||
<header class="app-topbar">
|
||||
<div class="flex items-center gap-3 px-4 sm:px-6 h-full">
|
||||
@@ -352,24 +374,4 @@ templ SidebarSignIn(currentPath string) {
|
||||
}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
<!-- Global confirm modal (issue #5): ONE styled dialog answers every
|
||||
hx-confirm sitewide via the htmx:confirm interceptor in
|
||||
web/src/confirm.ts, and exposes the confirmDialog() promise for
|
||||
legacy JS call sites. Inert until shown. -->
|
||||
<div
|
||||
id="confirm-modal"
|
||||
class="hidden fixed inset-0 z-[60] flex items-center justify-center p-4"
|
||||
style="background-color: var(--surface-overlay);"
|
||||
>
|
||||
<div class="card w-full max-w-sm" style="box-shadow: var(--shadow-pop);">
|
||||
<div class="p-5 border-b" style="border-color: var(--border);">
|
||||
<p id="confirm-modal-message" class="text-sm font-medium" style="color: var(--text-primary)"></p>
|
||||
</div>
|
||||
<div class="p-4 flex justify-end gap-2">
|
||||
<button id="confirm-modal-cancel" class="btn btn-secondary">Cancel</button>
|
||||
<button id="confirm-modal-accept" class="btn btn-primary">Confirm</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
}
|
||||
Reference in new issue
Block a user