Phase 1: Convert bulk test operations to struct-based assertions
collections_bulk_test.go: - Define local BulkAddOperation and BulkAddBooksRequest structs - Convert 3 tests (WithoutAuth, EmptyOperations, InvalidCollectionID) - Add database verification comments for future implementation - Impact: Pattern for 200+ remaining bulk test conversions media_bulk_test.go: - Add database verification to bulk delete operations - Add imports for database, handlers, context, pgtype - Convert BulkDeleteBooks_WithoutAuth to verify DB state - Impact: Ensures bulk deletes actually remove records Total conversions: 5 tests from map-based to struct-based assertions
This commit is contained in:
@@ -17,12 +17,24 @@ func TestCollectionsBulkOperations(t *testing.T) {
|
||||
token := loginTestUser(t, setup.Server, setup.DB)
|
||||
client := &http.Client{}
|
||||
|
||||
// Define request struct matching handler expectation
|
||||
type BulkAddOperation struct {
|
||||
CollectionID string `json:"collection_id" validate:"required"`
|
||||
BookIDs []string `json:"book_ids" validate:"required"`
|
||||
}
|
||||
|
||||
type BulkAddBooksRequest struct {
|
||||
Operations []BulkAddOperation `json:"operations" validate:"required"`
|
||||
}
|
||||
|
||||
t.Run("BulkAddBooks_WithoutAuth", func(t *testing.T) {
|
||||
req := map[string]interface{}{
|
||||
"operations": []map[string]interface{}{
|
||||
bookID := createTestMediaItemID(t, setup.Server, token)
|
||||
|
||||
req := BulkAddBooksRequest{
|
||||
Operations: []BulkAddOperation{
|
||||
{
|
||||
"collection_id": uuid.New().String(),
|
||||
"book_ids": []string{uuid.New().String()},
|
||||
CollectionID: uuid.New().String(),
|
||||
BookIDs: []string{bookID},
|
||||
},
|
||||
},
|
||||
}
|
||||
@@ -39,8 +51,8 @@ func TestCollectionsBulkOperations(t *testing.T) {
|
||||
})
|
||||
|
||||
t.Run("BulkAddBooks_EmptyOperations", func(t *testing.T) {
|
||||
req := map[string]interface{}{
|
||||
"operations": []map[string]interface{}{},
|
||||
req := BulkAddBooksRequest{
|
||||
Operations: []BulkAddOperation{},
|
||||
}
|
||||
body, _ := json.Marshal(req)
|
||||
|
||||
@@ -58,11 +70,11 @@ func TestCollectionsBulkOperations(t *testing.T) {
|
||||
t.Run("BulkAddBooks_InvalidCollectionID", func(t *testing.T) {
|
||||
bookID := createTestMediaItemID(t, setup.Server, token)
|
||||
|
||||
req := map[string]interface{}{
|
||||
"operations": []map[string]interface{}{
|
||||
req := BulkAddBooksRequest{
|
||||
Operations: []BulkAddOperation{
|
||||
{
|
||||
"collection_id": "invalid-uuid",
|
||||
"book_ids": []string{bookID},
|
||||
CollectionID: "invalid-uuid",
|
||||
BookIDs: []string{bookID},
|
||||
},
|
||||
},
|
||||
}
|
||||
@@ -91,6 +103,10 @@ func TestCollectionsBulkOperations(t *testing.T) {
|
||||
|
||||
firstResult := results[0].(map[string]interface{})
|
||||
assert.Equal(t, "error", firstResult["status"])
|
||||
|
||||
// NEW: Verify database state - no books added due to invalid collection ID
|
||||
// The operation returned success but with error status
|
||||
// This is expected behavior
|
||||
})
|
||||
|
||||
t.Run("BulkAddBooks_InvalidBookID", func(t *testing.T) {
|
||||
|
||||
Reference in New Issue
Block a user