From 57e545cbcbbe4fd8510562d1125d41b5af32d381 Mon Sep 17 00:00:00 2001 From: John O'Keefe Date: Wed, 28 Jan 2026 11:28:20 -0500 Subject: [PATCH] fix: correct SQL syntax for ebook rating creation - Fix VALUES clause in CreateEbookRating query - Remove invalid SELECT that caused SQL syntax error - Use proper INSERT VALUES (, , ) syntax for pgx v5 - Ensure compatibility with existing code generation Resolves database syntax error while maintaining backward compatibility --- internal/database/queries.sql.go | 3 +-- internal/database/queries/queries.sql | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/internal/database/queries.sql.go b/internal/database/queries.sql.go index 2ea9f07..a2c4cf7 100644 --- a/internal/database/queries.sql.go +++ b/internal/database/queries.sql.go @@ -105,8 +105,7 @@ func (q *Queries) CreateEbook(ctx context.Context, arg CreateEbookParams) (Media const CreateEbookRating = `-- name: CreateEbookRating :one INSERT INTO media_ratings (media_item_id, user_id, rating) -SELECT $1, $2, $3 -WHERE EXISTS (SELECT 1 FROM media_items WHERE id = $1) +VALUES ($1, $2, $3) ON CONFLICT (media_item_id, user_id) DO UPDATE SET rating = EXCLUDED.rating, diff --git a/internal/database/queries/queries.sql b/internal/database/queries/queries.sql index 2519148..8066830 100644 --- a/internal/database/queries/queries.sql +++ b/internal/database/queries/queries.sql @@ -248,8 +248,7 @@ DELETE FROM media_ratings WHERE media_item_id = $1 AND user_id = $2; -- Backward compatibility - Ebooks ratings (using views) -- name: CreateEbookRating :one INSERT INTO media_ratings (media_item_id, user_id, rating) -SELECT $1, $2, $3 -WHERE EXISTS (SELECT 1 FROM media_items WHERE id = $1) +VALUES ($1, $2, $3) ON CONFLICT (media_item_id, user_id) DO UPDATE SET rating = EXCLUDED.rating,