From 73e8cdef4b33e552dc2a6ce5da68c243610746f7 Mon Sep 17 00:00:00 2001 From: John O'Keefe Date: Sat, 24 Oct 2026 21:17:55 -0400 Subject: [PATCH] =?UTF-8?q?docs(ui):=20drop=20sidebar=20saved-state=20?= =?UTF-8?q?=E2=80=94=20server=20defaults=20already=20ARE=20the=20standard?= =?UTF-8?q?=20docs=20behavior?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Simplification per spec: the menu tracks state through the URL alone. Land on /docs: fully closed, headers only (an explicit home rule now overrides the contains-URL rule, since the root overview doc lives in Getting Started and would otherwise auto-open it). Land on any doc page: its containing section + group render open at first paint, current link bold — no JS, no jump, arrows consistent. Navigate elsewhere: old closes, new opens. Deleted: docs_nav cookie const/parse, ApplyNavOverrides, cookie write + collect/persist helpers in web/src/docs.ts, data-key attributes in the sidebar templ, and the first-section-open fallback (docs home used to force-open the first section — spec'd as closed). toggleCollapsible remains for in-page peeking; purely ephemeral. The [data-collapsed=true] CSS from the previous round stays — it is what makes the server-rendered state actually hide sections at paint (the original bug was that this CSS never existed). Tests: TestBuildNavigationNothingCurrent now asserts zero sections open on unmatched paths; TestBuildNavigation asserts Getting Started closed on a device page (no site-wide pin). make test green; 146 vitests; live verified: home 0 expanded, doc pages exactly 2 (section+group). --- internal/docs/http_handler.go | 29 ---- internal/docs/navigation.go | 71 +++----- internal/docs/navigation_test.go | 11 +- templates/docs.templ | 4 +- templates/docs_templ.go | 274 ++++++++++++++----------------- web/src/docs.ts | 38 +---- 6 files changed, 155 insertions(+), 272 deletions(-) diff --git a/internal/docs/http_handler.go b/internal/docs/http_handler.go index 7bb4d21a..f18035f7 100644 --- a/internal/docs/http_handler.go +++ b/internal/docs/http_handler.go @@ -2,10 +2,8 @@ package docs import ( "bytes" - "encoding/json" "fmt" "net/http" - "net/url" "strings" "bookhoard/internal/database" @@ -48,37 +46,10 @@ func (h *HTTPHandler) currentUser(c *echo.Context) templates.User { return templates.User{Theme: "tokyo-night"} } -// docsNavCookie is the browser-saved collapse state of the docs sidebar -// (set by web/src/docs.ts on every toggle). Strictly-necessary UI state: -// first-party, no identifiers, lets the server render the sidebar in the -// visitor's chosen state so there is no post-paint jump. -const docsNavCookie = "docs_nav" - -// docsNavOverrides reads the saved collapse state from the cookie. -// Keys are the sidebar's data-key values ("Section", "Section / Group"); -// values are the collapsed flag. Malformed cookies are ignored — the -// server-rendered defaults win. -func docsNavOverrides(c *echo.Context) map[string]bool { - cookie, err := c.Cookie(docsNavCookie) - if err != nil || cookie.Value == "" { - return nil - } - raw, err := url.QueryUnescape(cookie.Value) - if err != nil { - return nil - } - var overrides map[string]bool - if err := json.Unmarshal([]byte(raw), &overrides); err != nil { - return nil - } - return overrides -} - // renderDocPage renders a document inside the docs layout. func (h *HTTPHandler) renderDocPage(c *echo.Context, doc *templates.Document) error { currentPath := c.Request().URL.Path nav := h.docs.BuildNavigation(currentPath) - ApplyNavOverrides(nav, docsNavOverrides(c)) var buf bytes.Buffer if err := templates.DocsLayout(*nav, *doc, h.currentUser(c), currentPath).Render(c.Request().Context(), &buf); err != nil { diff --git a/internal/docs/navigation.go b/internal/docs/navigation.go index ed789290..299ea528 100644 --- a/internal/docs/navigation.go +++ b/internal/docs/navigation.go @@ -178,8 +178,8 @@ func docURL(docPath string) string { // BuildNavigation creates the category → subcategory navigation from the // docs filesystem. The section and group containing currentPath render -// expanded; everything else starts collapsed (with Getting Started as the -// fallback when nothing matches). +// expanded; everything else starts collapsed. When nothing matches (docs +// home, 404), the sidebar renders fully closed — headers only. func (h *DocsHandler) BuildNavigation(currentPath string) *templates.Navigation { docs, err := h.ListDocuments() if err != nil { @@ -198,16 +198,17 @@ func (h *DocsHandler) BuildNavigation(currentPath string) *templates.Navigation } type groupBuild struct { - items []templates.NavItem - urls []string - overview bool // has a pinned index page + items []templates.NavItem + urls []string + // overview: the group leads with its "#"Overview landing doc (pinned + // subdirectory index), so it sorts first. + overview bool } type sectionBuild struct { - items []templates.NavItem - urls []string - pinned map[string]bool // landing pages lead their section - groups map[string]*groupBuild - overview bool + items []templates.NavItem + urls []string + pinned map[string]bool // landing pages lead their section + groups map[string]*groupBuild } builds := make(map[string]*sectionBuild, len(sectionOrder)) @@ -231,10 +232,6 @@ func (h *DocsHandler) BuildNavigation(currentPath string) *templates.Navigation if place.pin < 0 { build.pinned[item.URL] = true } - if place.pin == -100 { - // Only the root Overview forces its section open. - build.overview = true - } } else { group, ok := build.groups[place.group] if !ok { @@ -301,52 +298,24 @@ func (h *DocsHandler) BuildNavigation(currentPath string) *templates.Navigation } } } - if build.overview { - section.Collapsed = false - } nav.Sections = append(nav.Sections, section) } - // Nothing matches the current page (404, search landing): open the - // first section so the sidebar doesn't render fully closed. - anyOpen := false - for _, s := range nav.Sections { - if !s.Collapsed { - anyOpen = true - break + // No default expansion when nothing matches the current page (404, + // search landing): the sidebar renders fully closed. Same for the docs + // HOME: although the root overview doc lives there (its contains-URL + // rule would open "Getting Started"), the spec is "home = all closed, + // headers only" — the standard docs-site behavior. + if strings.TrimSuffix(currentPath, "/") == "/docs" { + for si := range nav.Sections { + nav.Sections[si].Collapsed = true } - } - if !anyOpen && len(nav.Sections) > 0 { - nav.Sections[0].Collapsed = false + return nav } return nav } -// ApplyNavOverrides merges the browser-saved collapse state (docs_nav -// cookie) into the nav so the sidebar first-paints in the visitor's chosen -// state — no post-paint JS correction, no jumping. Keys mirror the -// data-key attributes DocsSidebar renders: section titles, and -// "Section / Group" for groups. Entries for unknown keys (renamed or -// removed sections) are ignored; keys absent from the map keep the -// path-derived default. -func ApplyNavOverrides(nav *templates.Navigation, overrides map[string]bool) { - if len(overrides) == 0 { - return - } - for si := range nav.Sections { - s := &nav.Sections[si] - if v, ok := overrides[s.Title]; ok { - s.Collapsed = v - } - for gi := range s.Groups { - if v, ok := overrides[s.Title+" / "+s.Groups[gi].Title]; ok { - s.Groups[gi].Collapsed = v - } - } - } -} - // containsURL reports whether currentPath is one of the given doc URLs. func containsURL(currentPath string, urls []string) bool { for _, u := range urls { diff --git a/internal/docs/navigation_test.go b/internal/docs/navigation_test.go index fd726e21..6583db83 100644 --- a/internal/docs/navigation_test.go +++ b/internal/docs/navigation_test.go @@ -127,8 +127,8 @@ func TestBuildNavigation(t *testing.T) { } getting := nav.Sections[0] - if getting.Collapsed { - t.Error("Getting Started should be expanded (root overview pinned)") + if !getting.Collapsed { + t.Error("Getting Started should be collapsed: only sections containing the current page open") } if len(getting.Items) != 1 || getting.Items[0].Title != "Overview" || getting.Items[0].URL != "/docs" { t.Errorf("Getting Started items = %+v, want single Overview → /docs", getting.Items) @@ -196,10 +196,7 @@ func TestBuildNavigationNothingCurrent(t *testing.T) { open++ } } - if open != 1 { - t.Errorf("expected exactly one section open on a 404 path, got %d", open) - } - if nav.Sections[0].Collapsed { - t.Error("fallback should open the first section") + if open != 0 { + t.Errorf("expected zero sections open when nothing matches (docs home / 404 renders fully closed), got %d", open) } } diff --git a/templates/docs.templ b/templates/docs.templ index c5de629f..a3360a71 100644 --- a/templates/docs.templ +++ b/templates/docs.templ @@ -198,7 +198,7 @@ templ DocsSidebar(nav Navigation, currentPath string) { @Icon("chevron-down", "h-4 w-4") -
+
for _, item := range section.Items { { item.Title } @@ -217,7 +217,7 @@ templ DocsSidebar(nav Navigation, currentPath string) { @Icon("chevron-down", "h-3.5 w-3.5") -
+
for _, item := range group.Items { { item.Title } diff --git a/templates/docs_templ.go b/templates/docs_templ.go index f4c248b5..b3fbef86 100644 --- a/templates/docs_templ.go +++ b/templates/docs_templ.go @@ -588,114 +588,101 @@ func DocsSidebar(nav Navigation, currentPath string) templ.Component { if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 53, "
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 54, "\">") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } for _, item := range section.Items { - var templ_7745c5c3_Var25 = []any{docsNavClass(currentPath, item.URL, "pl-7")} - templ_7745c5c3_Err = templ.RenderCSSItems(ctx, templ_7745c5c3_Buffer, templ_7745c5c3_Var25...) + var templ_7745c5c3_Var24 = []any{docsNavClass(currentPath, item.URL, "pl-7")} + templ_7745c5c3_Err = templ.RenderCSSItems(ctx, templ_7745c5c3_Buffer, templ_7745c5c3_Var24...) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 56, "") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } var templ_7745c5c3_Var27 string - templ_7745c5c3_Var27, templ_7745c5c3_Err = templ.ResolveAttributeValue(templ.CSSClasses(templ_7745c5c3_Var25).String()) - if templ_7745c5c3_Err != nil { - return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 1, Col: 0} - } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var27) - if templ_7745c5c3_Err != nil { - return templ_7745c5c3_Err - } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 58, "\">") - if templ_7745c5c3_Err != nil { - return templ_7745c5c3_Err - } - var templ_7745c5c3_Var28 string - templ_7745c5c3_Var28, templ_7745c5c3_Err = templ.JoinStringErrs(item.Title) + templ_7745c5c3_Var27, templ_7745c5c3_Err = templ.JoinStringErrs(item.Title) if templ_7745c5c3_Err != nil { return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 204, Col: 26} } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var28)) + _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var27)) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 59, " ") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 58, " ") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } } for _, group := range section.Groups { - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 60, "
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 63, "\">") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } for _, item := range group.Items { - var templ_7745c5c3_Var33 = []any{docsNavClass(currentPath, item.URL, "pl-9")} - templ_7745c5c3_Err = templ.RenderCSSItems(ctx, templ_7745c5c3_Buffer, templ_7745c5c3_Var33...) + var templ_7745c5c3_Var31 = []any{docsNavClass(currentPath, item.URL, "pl-9")} + templ_7745c5c3_Err = templ.RenderCSSItems(ctx, templ_7745c5c3_Buffer, templ_7745c5c3_Var31...) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 66, "") + if templ_7745c5c3_Err != nil { + return templ_7745c5c3_Err + } + var templ_7745c5c3_Var34 string + templ_7745c5c3_Var34, templ_7745c5c3_Err = templ.JoinStringErrs(item.Title) + if templ_7745c5c3_Err != nil { + return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 223, Col: 46} + } _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var34)) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 67, "\" class=\"") - if templ_7745c5c3_Err != nil { - return templ_7745c5c3_Err - } - var templ_7745c5c3_Var35 string - templ_7745c5c3_Var35, templ_7745c5c3_Err = templ.ResolveAttributeValue(templ.CSSClasses(templ_7745c5c3_Var33).String()) - if templ_7745c5c3_Err != nil { - return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 1, Col: 0} - } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ_7745c5c3_Var35) - if templ_7745c5c3_Err != nil { - return templ_7745c5c3_Err - } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 68, "\">") - if templ_7745c5c3_Err != nil { - return templ_7745c5c3_Err - } - var templ_7745c5c3_Var36 string - templ_7745c5c3_Var36, templ_7745c5c3_Err = templ.JoinStringErrs(item.Title) - if templ_7745c5c3_Err != nil { - return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 223, Col: 46} - } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var36)) - if templ_7745c5c3_Err != nil { - return templ_7745c5c3_Err - } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 69, "") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 67, "") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 70, "
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 68, "
") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 71, "
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 69, "
") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 72, "") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 70, "") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } @@ -820,77 +794,77 @@ func DocsSearchResults(results []SearchResultItem) templ.Component { }() } ctx = templ.InitializeContext(ctx) - templ_7745c5c3_Var37 := templ.GetChildren(ctx) - if templ_7745c5c3_Var37 == nil { - templ_7745c5c3_Var37 = templ.NopComponent + templ_7745c5c3_Var35 := templ.GetChildren(ctx) + if templ_7745c5c3_Var35 == nil { + templ_7745c5c3_Var35 = templ.NopComponent } ctx = templ.ClearChildren(ctx) if len(results) == 0 { - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 73, "
No matching pages.
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 71, "
No matching pages.
") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } } else { - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 74, "") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } @@ -917,12 +891,12 @@ func DocsNotFound(title string, message string) templ.Component { }() } ctx = templ.InitializeContext(ctx) - templ_7745c5c3_Var41 := templ.GetChildren(ctx) - if templ_7745c5c3_Var41 == nil { - templ_7745c5c3_Var41 = templ.NopComponent + templ_7745c5c3_Var39 := templ.GetChildren(ctx) + if templ_7745c5c3_Var39 == nil { + templ_7745c5c3_Var39 = templ.NopComponent } ctx = templ.ClearChildren(ctx) - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 82, "") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 80, "") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } @@ -930,20 +904,20 @@ func DocsNotFound(title string, message string) templ.Component { if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 83, "") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 81, "<meta charset=\"UTF-8\"><meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\"><title>") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - var templ_7745c5c3_Var42 string - templ_7745c5c3_Var42, templ_7745c5c3_Err = templ.JoinStringErrs(title) + var templ_7745c5c3_Var40 string + templ_7745c5c3_Var40, templ_7745c5c3_Err = templ.JoinStringErrs(title) if templ_7745c5c3_Err != nil { return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 267, Col: 17} } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var42)) + _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var40)) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 84, " - Bookhoard Documentation
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 82, " - Bookhoard Documentation
") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } @@ -951,33 +925,33 @@ func DocsNotFound(title string, message string) templ.Component { if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 85, "

") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 83, "

") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - var templ_7745c5c3_Var43 string - templ_7745c5c3_Var43, templ_7745c5c3_Err = templ.JoinStringErrs(title) + var templ_7745c5c3_Var41 string + templ_7745c5c3_Var41, templ_7745c5c3_Err = templ.JoinStringErrs(title) if templ_7745c5c3_Err != nil { return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 277, Col: 84} } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var43)) + _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var41)) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 86, "

") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 84, "

") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - var templ_7745c5c3_Var44 string - templ_7745c5c3_Var44, templ_7745c5c3_Err = templ.JoinStringErrs(message) + var templ_7745c5c3_Var42 string + templ_7745c5c3_Var42, templ_7745c5c3_Err = templ.JoinStringErrs(message) if templ_7745c5c3_Err != nil { return templ.Error{Err: templ_7745c5c3_Err, FileName: `docs.templ`, Line: 278, Col: 76} } - _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var44)) + _, templ_7745c5c3_Err = templ_7745c5c3_Buffer.WriteString(templ.EscapeString(templ_7745c5c3_Var42)) if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } - templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 87, "

Documentation Bookhoard
") + templ_7745c5c3_Err = templruntime.WriteString(templ_7745c5c3_Buffer, 85, "

Documentation Bookhoard
") if templ_7745c5c3_Err != nil { return templ_7745c5c3_Err } diff --git a/web/src/docs.ts b/web/src/docs.ts index 4b105a6e..328185e1 100644 --- a/web/src/docs.ts +++ b/web/src/docs.ts @@ -15,39 +15,13 @@ function toggleSidebar(): void { overlay.classList.toggle("hidden"); } -// Docs sidebar collapse persistence. Rendering ownership: the server -// renders what is expanded (navigation defaults + docs_nav cookie -// overrides merged in internal/docs), so first paint is already correct — -// no post-paint correction, no jumping. This module only records intent: -// every toggle rewrites the cookie with the full current state. - -const DOCS_NAV_COOKIE = "docs_nav"; - -type DocsNavState = Record; - -// collectDocsNavState reads the current collapsed flag of every -// collapsible in the sidebar straight from the DOM. -function collectDocsNavState(): DocsNavState { - const state: DocsNavState = {}; - document.querySelectorAll("[data-key][data-collapsed]").forEach((el) => { - const key = el.getAttribute("data-key"); - if (key) state[key] = el.getAttribute("data-collapsed") === "true"; - }); - return state; -} - -function persistDocsNavCookie(state: DocsNavState): void { - try { - // Strictly-necessary UI state: first-party, no identifiers, one year. - document.cookie = `${DOCS_NAV_COOKIE}=${encodeURIComponent(JSON.stringify(state))}; path=/; max-age=31536000; SameSite=Lax`; - } catch { - // Storage blocked: the sidebar still works, state just doesn't persist. - } -} +// Docs sidebar sections toggle open/closed in-page (purely client-local, +// ephemeral — the SERVER decides what is expanded on each page load from +// navigation defaults, so there is no saved state and nothing to jump). +// The data-collapsed attribute is the single source of truth: the +// stylesheet hides on it, and the arrow rotates relative to it. function applyCollapsed(items: HTMLElement, collapsed: boolean): void { - // The data-collapsed attribute is the single source of truth — the - // stylesheet hides on it, and the arrow is rotated relative to it. items.setAttribute("data-collapsed", collapsed ? "true" : "false"); const arrow = items.previousElementSibling?.querySelector(".section-arrow"); if (arrow) { @@ -60,9 +34,7 @@ function toggleCollapsible(header: HTMLElement): void { if (!items) return; const isCollapsed = items.getAttribute("data-collapsed") === "true"; - applyCollapsed(items, !isCollapsed); - persistDocsNavCookie(collectDocsNavState()); } let docsSearchTimeout: ReturnType | null = null;