Bookhoard/bookhoard
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

test(infrastructure): Configure pgxpool with max_conns=1

Browse Source 
Fix database connection exhaustion in tests by setting max_conns=1
when creating pgxpool via pgxpool.ParseConfig().

- Update setupTestServer() in test_helpers.go
- Update setupSyncTestDB() in sync_integration_test.go

This reduces per-test connection usage from 4 to 1, keeping total
connections well under PostgreSQL's default max_connections=100.

78 tests × 1 connection = 78 connections (down from 312 potential)

Fixes test failures: "FATAL: sorry, too many clients already"

See PROJECT_GUIDELINES.md Testing section for details.
This commit is contained in:
john-okeefe
2026-02-11 10:37:38 -05:00
parent 61115bc8cd
commit 891209b4bd
10 changed files with 124 additions and 478 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/server/tests/media_bulk_test.go
+4 -49
View File
@@ -13,9 +13,10 @@ import (
// TestMediaBulkOperations tests bulk media operations
func TestMediaBulkOperations(t *testing.T) {
t.Run("BulkDeleteBooks_WithoutAuth", func(t *testing.T) {
setup := setupTestServer(t)
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
t.Run("BulkDeleteBooks_WithoutAuth", func(t *testing.T) {
req := map[string]interface{}{
"media_item_ids": []string{uuid.New().String()},
}
@@ -33,10 +34,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkDeleteBooks_EmptyBookIDs", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
req := map[string]interface{}{
"media_item_ids": []string{},
}
@@ -55,10 +52,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkDeleteBooks_InvalidBookIDs", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
req := map[string]interface{}{
"media_item_ids": []string{"invalid-uuid", "another-invalid"},
}
@@ -85,11 +78,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkDeleteBooks_WithValidBooks", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
// Create test media items
mediaID1 := createTestMediaItemID(t, setup.Server, token)
mediaID2 := createTestMediaItemID(t, setup.Server, token)
mediaID3 := uuid.New().String()
@@ -117,15 +105,11 @@ func TestMediaBulkOperations(t *testing.T) {
assert.Equal(t, 3.0, result["total"])
// Check that deleted field exists and has at least 2 (the valid books)
if deleted, ok := result["deleted"].(float64); ok {
assert.True(t, deleted >= 2, "Should delete at least the valid books")
assert.True(t, deleted >= 2, "Should delete at least valid books")
}
})
t.Run("BulkDeleteBooks_InvalidRequestBody", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
// Send invalid JSON
httpReq, _ := http.NewRequest("POST", setup.Server.URL+"/api/media-items/bulk-delete", bytes.NewBuffer([]byte("invalid json")))
httpReq.Header.Set("Content-Type", "application/json")
@@ -140,8 +124,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_WithoutAuth", func(t *testing.T) {
setup := setupTestServer(t)
req := map[string]interface{}{
"media_item_updates": []map[string]interface{}{
{
@@ -166,10 +148,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_EmptyBookIDs", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
req := map[string]interface{}{
"media_item_updates": []map[string]interface{}{
{
@@ -195,10 +173,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_InvalidBookIDs", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
req := map[string]interface{}{
"media_item_updates": []map[string]interface{}{
{
@@ -232,11 +206,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_UpdateTags", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
// Create test media items
mediaID1 := createTestMediaItemID(t, setup.Server, token)
mediaID2 := createTestMediaItemID(t, setup.Server, token)
@@ -281,11 +250,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_UpdateReadingStatus", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
// Create test media items
mediaID1 := createTestMediaItemID(t, setup.Server, token)
req := map[string]interface{}{
@@ -318,11 +282,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_UpdateMultipleFields", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
// Create test media items
mediaID1 := createTestMediaItemID(t, setup.Server, token)
req := map[string]interface{}{
@@ -357,10 +316,6 @@ func TestMediaBulkOperations(t *testing.T) {
})
t.Run("BulkUpdateBooks_InvalidRequestBody", func(t *testing.T) {
setup := setupTestServer(t)
token := loginTestUser(t, setup.Server, setup.DB)
// Send invalid JSON
httpReq, _ := http.NewRequest("POST", setup.Server.URL+"/api/media-items/bulk-update", bytes.NewBuffer([]byte("invalid json")))
httpReq.Header.Set("Content-Type", "application/json")