feat(devices): pairing codes replace the registration broadcast
A pending device registration used to be announced to EVERY account's Devices page, and whoever clicked Approve first bound the device — and its freshly minted sync token — to their account. Worse, the pending card displayed the registration UUID, which is also the bearer credential on the unauthenticated /api/devices/register/status poll channel: any family user who could see the list already held everything needed to take the device. On a family server that is a wrong-account-binding bug (accidental or deliberate); this commit removes the class of problem rather than patching the race. The new model is the Netflix/YouTube TV device flow: the registering device displays a 6-digit pairing code, and the only person who can read it — whoever holds the device — types it into THEIR account on the Devices page. Possession of the device screen becomes the credential; nothing is broadcast; the reject-on-someone-else's-behalf hole dies with the list. Server changes: - POST /api/devices/register now mints pairing_code (crypto/rand, rejection-sampled for uniformity, collision-checked against live registrations) and retires prior unclaimed registrations with the same device_identifier, so re-registering leaves exactly one live attempt. - POST /api/devices/claim (JWT) binds the registration behind a code to the caller's account, reusing the rotate-or-create approval logic factored out of ApproveDevice (shared bindRegistrationToUser helper; the Android self-approval route keeps working unchanged). - POST /api/devices/claim/lookup (JWT) returns the confirm-card data without binding. Lookup and claim share a per-account budget (12 attempts/min, DeviceRateLimiter gained a claim case) — the 1M-code space over a 5-minute TTL makes guessing infeasible without it. - POST /api/devices/register/cancel lets the registering device end its own attempt (registration UUID bearer, idempotent, never touches a claimed registration). - ListPendingRegistrations / GetPendingRegistrationsData are deprecated-by-emptiness: unclaimed registrations return to nobody. - RejectDevice and its route are deleted — the broadcast list was its only consumer, and there is nothing left for anyone to reject. Additive-only for pinned surfaces: the register response gains pairing_code (Android DTO untouched), the four KOReader sync surfaces and approve keep byte-identical shapes. contract_pins.md changelog records the widening and the reject removal. Docs, schema registry, and bruno mirrors move together per the drift gate; bruno_gen.go now keeps hand-authored bruno/podcasts/ (API docs never existed for them, so the next -update run would have swept them — latent landmine, defused). Unit tests: code shape, live-collision avoidance, typed-code normalization, and the resolve scopes (live/expired/claimed/miss).
This commit is contained in:
1 parent
ab5c52c709
commit
8fbacd9f46
47 files changed
+935
-273
No files matched your search
+49
-11
@@ -1,7 +1,7 @@
|
||||
openapi: 3.0.3
|
||||
info:
|
||||
title: Bookhoard API
|
||||
version: '2026.10.27'
|
||||
version: '2026.11.02'
|
||||
description: |
|
||||
Generated from the canonical API docs (docs/developer/api/**) by
|
||||
internal/docs (go test ./internal/docs -run TestBrunoMirrorsDocs -update).
|
||||
@@ -395,7 +395,7 @@ paths:
|
||||
}
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
description: Success
|
||||
"/api/conflicts":
|
||||
get:
|
||||
tags: [conflicts]
|
||||
@@ -557,6 +557,38 @@ paths:
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
"/api/devices/claim":
|
||||
post:
|
||||
tags: [devices]
|
||||
summary: "Claim Device (Pairing Code)"
|
||||
security:
|
||||
- bearerAuth: []
|
||||
requestBody:
|
||||
content:
|
||||
application/json:
|
||||
example: |-
|
||||
{
|
||||
"pairing_code": "583912"
|
||||
}
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
"/api/devices/claim/lookup":
|
||||
post:
|
||||
tags: [devices]
|
||||
summary: "Look Up Pairing Code"
|
||||
security:
|
||||
- bearerAuth: []
|
||||
requestBody:
|
||||
content:
|
||||
application/json:
|
||||
example: |-
|
||||
{
|
||||
"pairing_code": "583912"
|
||||
}
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
"/api/devices/pending":
|
||||
get:
|
||||
tags: [devices]
|
||||
@@ -583,6 +615,21 @@ paths:
|
||||
responses:
|
||||
'201':
|
||||
description: Created
|
||||
"/api/devices/register/cancel":
|
||||
post:
|
||||
tags: [devices]
|
||||
summary: "Cancel Device Registration"
|
||||
security: []
|
||||
requestBody:
|
||||
content:
|
||||
application/json:
|
||||
example: |-
|
||||
{
|
||||
"registration_id": "550e8400-e29b-41d4-a716-446655440000"
|
||||
}
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
"/api/devices/register/status":
|
||||
post:
|
||||
tags: [devices]
|
||||
@@ -598,15 +645,6 @@ paths:
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
"/api/devices/reject/{registration_id}":
|
||||
post:
|
||||
tags: [devices]
|
||||
summary: "Reject Device Registration"
|
||||
security:
|
||||
- bearerAuth: []
|
||||
responses:
|
||||
'200':
|
||||
description: OK
|
||||
"/api/devices/{deviceId}/sync/link-book":
|
||||
post:
|
||||
tags: [book-matching]
|
||||
|
||||
Reference in new issue
Block a user