From ab4bddc784f0669d2c5858fd80a2dbc72d810693 Mon Sep 17 00:00:00 2001 From: John O'Keefe Date: Thu, 29 Oct 2026 12:21:03 -0400 Subject: [PATCH] fix(compose): drop vestigial uploads mount from db service MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The db service mounted ./uploads:/app/uploads, which Postgres has never used and nothing in the repo relies on: no SQL COPY TO/pg_dump path, no doc/test reference to an uploads path inside the db container (the only /app/uploads mentions in TEST_DATA.md are the app/test containers), and the backup scan is app-side. Forensics: the mount was introduced by accident in 6ebe9749 ("Simplify docker-compose healthcheck configuration"), which incidentally REPLACED the db service's volumes with the app service's uploads mount. The follow-up 91456d11 ("restore essential database configuration") restored postgres_data and the schema-init mount but nobody noticed the stray uploads mount riding along, and it has survived every compose refactor since. The tests service in docker-compose.dev.yml keeps its own ./uploads mount — that is the app-like test runner (TEST_UPLOAD_PATH=/app/uploads) and is legitimate. The dev db inherits its volumes from the base file, so it is fixed automatically. --- docker-compose.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/docker-compose.yml b/docker-compose.yml index 64d72b37..e8ffcd13 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -12,8 +12,6 @@ services: volumes: - postgres_data:/var/lib/postgresql/data - ./database/schema:/docker-entrypoint-initdb.d - # Make other volumes as needed - - ./uploads:/app/uploads ports: - "127.0.0.1:${DB_PORT:-5432}:${DB_PORT:-5432}" - "[::1]:${DB_PORT:-5432}:${DB_PORT:-5432}"