refactor(templates): remove duplicate main.js script tags, consolidate to header component

Remove redundant <script src="/static/main.js" defer></script> tags from 17+
templates that include the @Header component, eliminating duplicate script
loading that was causing Alpine.js to initialize twice per page load.

The header.templ component now serves as the single source of truth for
main.js inclusion, following the DRY principle and ensuring consistent
script loading across all pages that use the header navigation.

Additionally, add type="button" attribute to all buttons in header navigation
to prevent default form submission behavior when buttons are clicked.

Changes:
- Remove main.js script tag from templates using @Header component
- Keep main.js in header.templ (line 279) as universal inclusion point
- Preserve main.js in special pages: index.templ, login.templ, register.templ
  (these don't use @Header and are standalone entry points)
- Add type="button" to theme toggle, theme selection, wood paneling, and user menu buttons
  to prevent unwanted form submissions or page navigation

Benefits:
- Eliminates Alpine.js double-initialization bug
- Reduces HTTP requests (one script load instead of two)
- Improves maintainability (add header, get scripts automatically)
- Fixes broken @click handlers on collections, devices, and other pages
- Prevents buttons from triggering default form submission behavior

Technical notes:
- Templates affected: admin, analytics, bookshelf, collection_rules,
  collections, conflicts, custom_section, dashboard, devices, docs,
  library, profile, progress, queue, unlinked_books
- No changes to entry pages (index, login, register) which don't use @Header
- HTMX script remains in individual templates (stateless, no double-load issue)
- All interactive buttons in header now explicitly marked type="button" to
  prevent default browser form submission behavior

Related to: previous commit fixing Vite code-splitting

This commit is contained in:

john-okeefe

2026-03-13 22:25:12 -04:00

parent f73ca5fdab

commit af7533529c

36 changed files with 165 additions and 173 deletions

									
										templates/unlinked_books.templ
									
		-1
	
												View File
												
				@@ -8,7 +8,6 @@ templ UnlinkedBooks(user User, unlinkedBooks []UnlinkedBookData) {

							<meta name="viewport" content="width=device-width, initial-scale=1.0"/>

							<title>Unlinked Books - Bookhoard</title>

							<script src="/static/htmx.min.js"></script>

							<script src="/static/main.js" defer></script>

							<link href="/static/style.css" rel="stylesheet"/>

						</head>

						<body class="theme-{ user.Theme }" x-data="unlinkedBooks" x-init="setupEventDelegation()">