test: rewrite system_settings tests to use real handlers and add regular user support

cmd/server/tests/test_helpers.go

@@ -405,6 +405,7 @@ func setupTestServer(t *testing.T) *TestServerSetup {
 	conflictHandler := handlers.NewConflictHandler(queries, connManager)
 	analyticsHandler := handlers.NewAnalyticsHandler(queries)
 	queueHandler := handlers.NewQueueHandler(queries, queueProcessor)
+	systemSettingsHandler := handlers.NewSystemSettingsHandler(queries)
 
 	// Create refactored handlers (matching main.go)
 	libraryService := services.NewLibraryService(queries)
@@ -434,26 +435,27 @@ func setupTestServer(t *testing.T) *TestServerSetup {
 
 	// Setup routes using router package
 	routerConfig := &router.Config{
-		Echo:                 e,
-		Queries:              queries,
-		Cfg:                  cfg,
-		DBPool:               dbPool,
-		AuthHandler:          authHandler,
-		LibraryHandler:       libraryHandler,
-		DeviceHandler:        deviceHandler,
-		MediaHandler:         mediaHandler,
-		MatchingHandler:      matchingHandler,
-		KOReaderHandler:      koreaderHandler,
-		WSHandler:            wsHandler,
-		ConflictHandler:      conflictHandler,
-		AnalyticsHandler:     analyticsHandler,
-		QueueHandler:         queueHandler,
-		CollectionHandler:    collectionHandler,
-		OPDSHandler:          opdsHandler,
-		ConnManager:          connManager,
-		QueueProcessor:       queueProcessor,
-		DeviceAuthMiddleware: deviceAuthMiddleware,
-		LoginTracker:         loginAttemptTracker,
+		Echo:                  e,
+		Queries:               queries,
+		Cfg:                   cfg,
+		DBPool:                dbPool,
+		AuthHandler:           authHandler,
+		LibraryHandler:        libraryHandler,
+		DeviceHandler:         deviceHandler,
+		MediaHandler:          mediaHandler,
+		MatchingHandler:       matchingHandler,
+		KOReaderHandler:       koreaderHandler,
+		WSHandler:             wsHandler,
+		ConflictHandler:       conflictHandler,
+		AnalyticsHandler:      analyticsHandler,
+		QueueHandler:          queueHandler,
+		SystemSettingsHandler: systemSettingsHandler,
+		CollectionHandler:     collectionHandler,
+		OPDSHandler:           opdsHandler,
+		ConnManager:           connManager,
+		QueueProcessor:        queueProcessor,
+		DeviceAuthMiddleware:  deviceAuthMiddleware,
+		LoginTracker:          loginAttemptTracker,
 	}
 
 	router.RegisterRoutes(routerConfig)
@@ -549,6 +551,70 @@ func getTestUserID(t *testing.T, db *database.Queries) uuid.UUID {
 	return userUUID
 }
 
+func loginRegularUser(t *testing.T, ts *httptest.Server, db *database.Queries) string {
+	// Ensure test user exists first
+	_ = getRegularUserID(t, db)
+
+	loginRequest := map[string]interface{}{
+		"login":    "testregularuser@example.com",
+		"password": "Test@Pass123!",
+	}
+	body, _ := json.Marshal(loginRequest)
+
+	req, _ := http.NewRequest("POST", ts.URL+"/api/auth/login", bytes.NewBuffer(body))
+	req.Header.Set("Content-Type", "application/json")
+
+	client := &http.Client{}
+	resp, err := client.Do(req)
+	require.NoError(t, err, "Failed to login test user")
+	defer resp.Body.Close()
+
+	require.Equal(t, http.StatusOK, resp.StatusCode, "Login should succeed")
+
+	var result map[string]interface{}
+	json.NewDecoder(resp.Body).Decode(&result)
+
+	token, ok := result["access_token"].(string)
+	require.True(t, ok, "Should have access_token")
+	require.NotEmpty(t, token, "Access token should not be empty")
+
+	return token
+}
+
+func getRegularUserID(t *testing.T, db *database.Queries) uuid.UUID {
+	ctx := context.Background()
+
+	// Check if test user exists and delete them first to ensure fresh state
+	user, err := db.GetUserByEmail(ctx, "testregularuser@example.com")
+	if err == nil {
+		// User exists, delete them to ensure fresh password
+		err = db.DeleteUser(ctx, user.ID)
+		if err != nil {
+			// If delete fails (user might be referenced elsewhere), log and continue
+			t.Logf("Warning: Could not delete existing test user: %v", err)
+		}
+	}
+
+	// Create a fresh test user with a valid password
+	// Password: "Test@Pass123!" meets complexity requirements
+	// This is the bcrypt hash for "Test@Pass123!"
+	passwordHash := "$2a$10$JjAtK7PPa1WexQC3AUGe8OXLeuseZ/haN1Mz7emMo6CfOvMiTVXWq"
+
+	newUser, err := db.CreateUser(ctx, database.CreateUserParams{
+		Email:        "testregularuser@example.com",
+		Username:     "testregularuser",
+		PasswordHash: passwordHash,
+		FirstName:    pgtype.Text{String: "Test", Valid: true},
+		LastName:     pgtype.Text{String: "User", Valid: true},
+		Role:         "user",
+	})
+	require.NoError(t, err, "Failed to create test user")
+
+	userUUID, err := uuid.FromBytes(newUser.ID.Bytes[:])
+	require.NoError(t, err, "Failed to parse user UUID")
+	return userUUID
+}
+
 // createTestMediaItemID creates a test media item and returns its ID
 func createTestMediaItemID(t *testing.T, ts *httptest.Server) string {
 	// Generate unique library name to avoid conflicts between tests