feat(filters): per-row AND/OR (Excel-style chips) + browse-on-click value menus (user report)

- Per-rule connectives: the chip before each rule flips that rule
  between AND and OR — OR-joined neighbors merge into an invisible
  OR-block, AND pulls them back out. The tree stays the single source
  of truth (implicit blocks are a client marker the server ignores),
  so deep links, saved filters, and the composed engine are untouched.
  Group-mode pills are gone; explicit groups remain as pure structure
  (+ group). Compile limit, same as Excel: flat chips express
  AND-of-OR-groups; a top-level OR of AND-blocks still needs nesting.
- Browse-on-click: clicking an empty value box now fetches the field's
  top values UNDER the other rules (blank typed = browse, not a
  similarity filter) — 'assign an author, click Publisher, see their
  publishers' without typing. Server: the composed suggestion engine
  trims the typed query; client: the >=2-char guard no longer blocks
  the empty query, browse limit 15 vs 8 while typing.
- Tests: the browse case pinned (blank sentinel + rules → the field's
  values under those rules, zero-match values absent).

web/src/filter_builder.ts

@@ -224,6 +224,10 @@ export interface FilterRuleState {
 export interface FilterGroupState {
   mode: "all" | "any";
   children: (FilterRuleState | FilterGroupState)[];
+  // Client-side marker: an OR-block built by the per-row connective
+  // chips (Excel-style rows). Invisible in the UI — its children render
+  // as one flat list; the server ignores the extra JSON key.
+  implicit?: boolean;
 }
 
 export const isRule = (n: FilterRuleState | FilterGroupState): n is FilterRuleState =>
@@ -319,7 +323,9 @@ function pruneIncomplete(
     children.push({ field: child.field, op: child.op, values: [kept.join(",")] });
   });
   if (children.length === 0) return null;
-  return { mode: group.mode, children };
+  const out: FilterGroupState = { mode: group.mode, children };
+  if (group.implicit) out.implicit = true;
+  return out;
 }
 
 // ─── row projection (flat rendering of the nested tree) ─────────────
@@ -329,7 +335,11 @@ export interface BuilderRow {
   path: number[];
   type: "rule" | "groupOpen" | "groupClose";
   depth: number;
-  connective: "AND" | "OR";
+  // How this row joins the row above: AND | OR. Clickable on rules
+  // where toggling restructures the tree (Excel-style per-row
+  // connective); static on group boundaries and first rows.
+  chip: "AND" | "OR";
+  chipClickable: boolean;
   isFirst: boolean;
   rule?: FilterRuleState;
   group?: FilterGroupState;
@@ -344,34 +354,68 @@ function projectRows(
   group.children.forEach((child, idx) => {
     const childPath = [...path, idx];
     const key = childPath.join("-");
+    // The slot chip: how this child joins the row above it.
+    const slotChip: "AND" | "OR" =
+      idx === 0 || group.mode === "all" ? "AND" : "OR";
     if (!isRule(child)) {
+      const g = child as FilterGroupState;
+      if (g.implicit) {
+        // Invisible OR-block: its children continue the flat list —
+        // the first inherits this slot's chip, the rest are ORs.
+        g.children.forEach((sub, j) => {
+          const subPath = [...childPath, j];
+          const subKey = subPath.join("-");
+          if (!isRule(sub)) {
+            return; // implicit blocks hold rules only
+          }
+          out.push({
+            key: subKey,
+            path: subPath,
+            type: "rule",
+            depth,
+            chip: j === 0 ? slotChip : "OR",
+            chipClickable: j > 0,
+            isFirst: idx === 0 && j === 0,
+            rule: sub,
+          });
+        });
+        return;
+      }
       out.push({
         key,
         path: childPath,
         type: "groupOpen",
         depth,
-        connective: group.mode === "all" ? "AND" : "OR",
+        chip: slotChip,
+        chipClickable: false,
         isFirst: idx === 0,
-        group: child,
+        group: g,
       });
-      projectRows(child, childPath, depth + 1, out);
+      projectRows(g, childPath, depth + 1, out);
       out.push({
         key: key + "-close",
         path: childPath,
         type: "groupClose",
         depth,
-        connective: group.mode === "all" ? "AND" : "OR",
+        chip: slotChip,
+        chipClickable: false,
         isFirst: idx === 0,
-        group: child,
+        group: g,
       });
       return;
     }
+    const prev = group.children[idx - 1];
+    const clickable =
+      idx > 0 &&
+      !!prev &&
+      (isRule(prev) || !!(prev as FilterGroupState).implicit);
     out.push({
       key,
       path: childPath,
       type: "rule",
       depth,
-      connective: group.mode === "all" ? "AND" : "OR",
+      chip: slotChip,
+      chipClickable: clickable,
       isFirst: idx === 0,
       rule: child,
     });
@@ -471,7 +515,7 @@ export function filterBuilderData() {
       const parent = this.nodeAt(path);
       if (!parent || !("children" in parent)) return;
       (parent as FilterGroupState).children.push({
-        mode: "any",
+        mode: "all",
         children: [{ field: "author", op: "contains", values: [] }],
       });
       this._touch();
@@ -486,19 +530,54 @@ export function filterBuilderData() {
       if (this.openMenu.startsWith(path.join("-") + ":")) this.openMenu = "";
       this._touch();
     },
-    setGroupMode(path: number[], mode: "all" | "any"): void {
-      const node = this.nodeAt(path);
-      if (!node || !("children" in node)) return;
-      (node as FilterGroupState).mode = mode;
-      this._touch();
-    },
-    // toggleGroupMode flips a group between AND and OR (the clickable
-    // connective between rules targets its parent group).
-    toggleGroupMode(parentPath: number[]): void {
-      const node = this.nodeAt(parentPath);
-      if (!node || !("children" in node)) return;
-      const group = node as FilterGroupState;
-      group.mode = group.mode === "all" ? "any" : "all";
+    // toggleRuleConnective — Excel-style per-row AND/OR. Clicking the
+    // chip before a rule flips how THAT rule joins the row above:
+    // AND → OR moves it into an implicit OR-block with the previous
+    // rule(s); OR → AND pulls it back out to the top level. The tree
+    // stays the single source of truth; nothing else changes.
+    toggleRuleConnective(rulePath: number[]): void {
+      const parentPath = rulePath.slice(0, -1);
+      const parent = this.nodeAt(parentPath);
+      if (!parent || !("children" in parent)) return;
+      const list = parent as FilterGroupState;
+      const idx = rulePath[rulePath.length - 1];
+      const rule = list.children[idx];
+      if (!rule || !isRule(rule)) return;
+
+      if (list.implicit) {
+        // OR → AND: pull the rule out of the OR-block, re-inserting it
+        // right after the block at the parent level.
+        const gpPath = parentPath.slice(0, -1);
+        const gp = this.nodeAt(gpPath);
+        if (!gp || !("children" in gp)) return;
+        const gpList = gp as FilterGroupState;
+        const blockIdx = parentPath[parentPath.length - 1];
+        list.children.splice(idx, 1);
+        gpList.children.splice(blockIdx + 1, 0, rule);
+        if (list.children.length === 1) {
+          gpList.children.splice(blockIdx, 1, list.children[0]);
+        } else if (list.children.length === 0) {
+          gpList.children.splice(blockIdx, 1);
+        }
+      } else {
+        // AND → OR: join the previous sibling rule / OR-block.
+        if (idx === 0) return;
+        const prev = list.children[idx - 1];
+        if (!prev) return;
+        if (isRule(prev)) {
+          const block: FilterGroupState = {
+            mode: "any",
+            implicit: true,
+            children: [prev, rule],
+          };
+          list.children.splice(idx - 1, 2, block);
+        } else if ((prev as FilterGroupState).implicit) {
+          (prev as FilterGroupState).children.push(rule);
+          list.children.splice(idx, 1);
+        } else {
+          return; // previous is an explicit group: no row-level toggle
+        }
+      }
       this._touch();
     },
     setRuleField(path: number[], key: string): void {
@@ -613,8 +692,12 @@ export function filterBuilderData() {
       if (!meta || !meta.suggest) return;
       // Fixed-option fields never hit the server.
       if (meta.valueKind === "fixed") return;
-      const typed = rule.values[0] ?? "";
-      if (typed.trim().length < 2 && meta.valueKind !== "id") return;
+      const typed = (rule.values[0] ?? "").trim();
+      // 1 char is too little to filter on; EMPTY means BROWSE — the
+      // user clicked the box to see the field's top values under the
+      // other rules (the server answers the blank query with the
+      // un-typed top list).
+      if (typed.length === 1) return;
       const token = localStorage.getItem("token");
       if (!token) return;
       // Symmetry: the tree sent EXCLUDES the rule being edited — the
@@ -622,13 +705,15 @@ export function filterBuilderData() {
       // rules are not filters; sending them would be a 400).
       const others = this.completedTree(path);
       const params = new URLSearchParams();
-      params.set(rule.field, typed.trim() || " ");
+      params.set(rule.field, typed || " ");
       if (others) params.set("qf", JSON.stringify(others));
       const currentLibraryId = (
         document.getElementById("library-select") as HTMLSelectElement
       )?.value;
       if (currentLibraryId) params.set("library_id", currentLibraryId);
-      params.set("limit", "8");
+      // Browse (no typing) shows a slightly wider window than filter-
+      // as-you-type.
+      params.set("limit", typed ? "8" : "15");
       try {
         const response = await fetch(`/api/media-items/search?${params.toString()}`, {
           headers: { Authorization: `Bearer ${token}` },

web/static/input.css

@@ -2080,3 +2080,8 @@
     color: var(--accent);
     border-color: color-mix(in srgb, var(--accent) 45%, var(--border));
   }
+  .fb-chip-static {
+    border-style: solid;
+    opacity: 0.7;
+    cursor: default;
+  }

web/static/style.css

@@ -1,2 +1,2 @@
 *,:after,:before{--tw-border-spacing-x:0;--tw-border-spacing-y:0;--tw-translate-x:0;--tw-translate-y:0;--tw-rotate:0;--tw-skew-x:0;--tw-skew-y:0;--tw-scale-x:1;--tw-scale-y:1;--tw-pan-x: ;--tw-pan-y: ;--tw-pinch-zoom: ;--tw-scroll-snap-strictness:proximity;--tw-gradient-from-position: ;--tw-gradient-via-position: ;--tw-gradient-to-position: ;--tw-ordinal: ;--tw-slashed-zero: ;--tw-numeric-figure: ;--tw-numeric-spacing: ;--tw-numeric-fraction: ;--tw-ring-inset: ;--tw-ring-offset-width:0px;--tw-ring-offset-color:#fff;--tw-ring-color:rgba(59,130,246,.5);--tw-ring-offset-shadow:0 0 #0000;--tw-ring-shadow:0 0 #0000;--tw-shadow:0 0 #0000;--tw-shadow-colored:0 0 #0000;--tw-blur: ;--tw-brightness: ;--tw-contrast: ;--tw-grayscale: ;--tw-hue-rotate: ;--tw-invert: ;--tw-saturate: ;--tw-sepia: ;--tw-drop-shadow: ;--tw-backdrop-blur: ;--tw-backdrop-brightness: ;--tw-backdrop-contrast: ;--tw-backdrop-grayscale: ;--tw-backdrop-hue-rotate: ;--tw-backdrop-invert: ;--tw-backdrop-opacity: ;--tw-backdrop-saturate: ;--tw-backdrop-sepia: ;--tw-contain-size: ;--tw-contain-layout: ;--tw-contain-paint: ;--tw-contain-style: }::backdrop{--tw-border-spacing-x:0;--tw-border-spacing-y:0;--tw-translate-x:0;--tw-translate-y:0;--tw-rotate:0;--tw-skew-x:0;--tw-skew-y:0;--tw-scale-x:1;--tw-scale-y:1;--tw-pan-x: ;--tw-pan-y: ;--tw-pinch-zoom: ;--tw-scroll-snap-strictness:proximity;--tw-gradient-from-position: ;--tw-gradient-via-position: ;--tw-gradient-to-position: ;--tw-ordinal: ;--tw-slashed-zero: ;--tw-numeric-figure: ;--tw-numeric-spacing: ;--tw-numeric-fraction: ;--tw-ring-inset: ;--tw-ring-offset-width:0px;--tw-ring-offset-color:#fff;--tw-ring-color:rgba(59,130,246,.5);--tw-ring-offset-shadow:0 0 #0000;--tw-ring-shadow:0 0 #0000;--tw-shadow:0 0 #0000;--tw-shadow-colored:0 0 #0000;--tw-blur: ;--tw-brightness: ;--tw-contrast: ;--tw-grayscale: ;--tw-hue-rotate: ;--tw-invert: ;--tw-saturate: ;--tw-sepia: ;--tw-drop-shadow: ;--tw-backdrop-blur: ;--tw-backdrop-brightness: ;--tw-backdrop-contrast: ;--tw-backdrop-grayscale: ;--tw-backdrop-hue-rotate: ;--tw-backdrop-invert: ;--tw-backdrop-opacity: ;--tw-backdrop-saturate: ;--tw-backdrop-sepia: ;--tw-contain-size: ;--tw-contain-layout: ;--tw-contain-paint: ;--tw-contain-style: }
-/*! tailwindcss v3.4.19 | MIT License | https://tailwindcss.com*/*,:after,:before{box-sizing:border-box;border:0 solid #e5e7eb}:after,:before{--tw-content:""}:host,html{line-height:1.5;-webkit-text-size-adjust:100%;-moz-tab-size:4;-o-tab-size:4;tab-size:4;font-family:ui-sans-serif,system-ui,sans-serif,Noto Sans SC,Noto Sans TC,Noto Sans JP,Noto Sans KR,PingFang SC,Microsoft YaHei,Hiragino Sans,Apple SD Gothic Neo,Apple Color Emoji,Segoe UI Emoji,Segoe UI Symbol,Noto Color Emoji;font-feature-settings:normal;font-variation-settings:normal;-webkit-tap-highlight-color:transparent}body{margin:0;line-height:inherit}hr{height:0;color:inherit;border-top-width:1px}abbr:where([title]){-webkit-text-decoration:underline dotted;text-decoration:underline dotted}h1,h2,h3,h4,h5,h6{font-size:inherit;font-weight:inherit}a{color:inherit;text-decoration:inherit}b,strong{font-weight:bolder}code,kbd,pre,samp{font-family:ui-monospace,SFMono-Regular,Menlo,Monaco,Consolas,Liberation Mono,Courier New,monospace;font-feature-settings:normal;font-variation-settings:normal;font-size:1em}small{font-size:80%}sub,sup{font-size:75%;line-height:0;position:relative;vertical-align:baseline}sub{bottom:-.25em}sup{top:-.5em}table{text-indent:0;border-color:inherit;border-collapse:collapse}button,input,optgroup,select,textarea{font-family:inherit;font-feature-settings:inherit;font-variation-settings:inherit;font-size:100%;font-weight:inherit;line-height:inherit;letter-spacing:inherit;color:inherit;margin:0;padding:0}button,select{text-transform:none}button,input:where([type=button]),input:where([type=reset]),input:where([type=submit]){-webkit-appearance:button;background-color:transparent;background-image:none}:-moz-focusring{outline:auto}:-moz-ui-invalid{box-shadow:none}progress{vertical-align:baseline}::-webkit-inner-spin-button,::-webkit-outer-spin-button{height:auto}[type=search]{-webkit-appearance:textfield;outline-offset:-2px}::-webkit-search-decoration{-webkit-appearance:none}::-webkit-file-upload-button{-webkit-appearance:button;font:inherit}summary{display:list-item}blockquote,dd,dl,figure,h1,h2,h3,h4,h5,h6,hr,p,pre{margin:0}fieldset{margin:0}fieldset,legend{padding:0}menu,ol,ul{list-style:none;margin:0;padding:0}dialog{padding:0}textarea{resize:vertical}input::-moz-placeholder,textarea::-moz-placeholder{opacity:1;color:#9ca3af}input::placeholder,textarea::placeholder{opacity:1;color:#9ca3af}[role=button],button{cursor:pointer}:disabled{cursor:default}audio,canvas,embed,iframe,img,object,svg,video{display:block;vertical-align:middle}img,video{max-width:100%;height:auto}[hidden]:where(:not([hidden=until-found])){display:none}input:where(:not([type])),input:where([type=date]),input:where([type=datetime-local]),input:where([type=email]),input:where([type=month]),input:where([type=number]),input:where([type=password]),input:where([type=search]),input:where([type=tel]),input:where([type=text]),input:where([type=time]),input:where([type=url]),input:where([type=week]),select,select:where([multiple]),textarea{-webkit-appearance:none;-moz-appearance:none;appearance:none;background-color:#fff;border-color:#6b7280;border-width:1px;border-radius:0;padding:.5rem .75rem;font-size:1rem;line-height:1.5rem;--tw-shadow:0 0 #0000}input:where(:not([type])):focus,input:where([type=date]):focus,input:where([type=datetime-local]):focus,input:where([type=email]):focus,input:where([type=month]):focus,input:where([type=number]):focus,input:where([type=password]):focus,input:where([type=search]):focus,input:where([type=tel]):focus,input:where([type=text]):focus,input:where([type=time]):focus,input:where([type=url]):focus,input:where([type=week]):focus,select:focus,select:where([multiple]):focus,textarea:focus{outline:2px solid transparent;outline-offset:2px;--tw-ring-inset:var(--tw-empty,/*!*/ /*!*/);--tw-ring-offset-width:0px;--tw-ring-offset-color:#fff;--tw-ring-color:#2563eb;--tw-ring-offset-shadow:var(--tw-ring-inset) 0 0 0 var(--tw-ring-offset-width) var(--tw-ring-offset-color);--tw-ring-shadow:var(--tw-ring-inset) 0 0 0 calc(1px + var(--tw-ring-offset-width)) var(--tw-ring-color);box-shadow:var(--tw-ring-offset-shadow),var(--tw-ring-shadow),var(--tw-shadow);border-color:#2563eb}input::-moz-placeholder,textarea::-moz-placeholder{color:#6b7280;opacity:1}input::placeholder,textarea::placeholder{color:#6b7280;opacity:1}::-webkit-datetime-edit-fields-wrapper{padding:0}::-webkit-date-and-time-value{min-height:1.5em;text-align:inherit}::-webkit-datetime-edit{display:inline-flex}::-webkit-datetime-edit,::-webkit-datetime-edit-day-field,::-webkit-datetime-edit-hour-field,::-webkit-datetime-edit-meridiem-field,::-webkit-datetime-edit-millisecond-field,::-webkit-datetime-edit-minute-field,::-webkit-datetime-edit-month-field,::-webkit-datetime-edit-second-field,::-webkit-datetime-edit-year-field{padding-top:0;padding-bottom:0}select{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='none' viewBox='0 0 20 20'%3E%3Cpath Line truncated
+/*! tailwindcss v3.4.19 | MIT License | https://tailwindcss.com*/*,:after,:before{box-sizing:border-box;border:0 solid #e5e7eb}:after,:before{--tw-content:""}:host,html{line-height:1.5;-webkit-text-size-adjust:100%;-moz-tab-size:4;-o-tab-size:4;tab-size:4;font-family:ui-sans-serif,system-ui,sans-serif,Noto Sans SC,Noto Sans TC,Noto Sans JP,Noto Sans KR,PingFang SC,Microsoft YaHei,Hiragino Sans,Apple SD Gothic Neo,Apple Color Emoji,Segoe UI Emoji,Segoe UI Symbol,Noto Color Emoji;font-feature-settings:normal;font-variation-settings:normal;-webkit-tap-highlight-color:transparent}body{margin:0;line-height:inherit}hr{height:0;color:inherit;border-top-width:1px}abbr:where([title]){-webkit-text-decoration:underline dotted;text-decoration:underline dotted}h1,h2,h3,h4,h5,h6{font-size:inherit;font-weight:inherit}a{color:inherit;text-decoration:inherit}b,strong{font-weight:bolder}code,kbd,pre,samp{font-family:ui-monospace,SFMono-Regular,Menlo,Monaco,Consolas,Liberation Mono,Courier New,monospace;font-feature-settings:normal;font-variation-settings:normal;font-size:1em}small{font-size:80%}sub,sup{font-size:75%;line-height:0;position:relative;vertical-align:baseline}sub{bottom:-.25em}sup{top:-.5em}table{text-indent:0;border-color:inherit;border-collapse:collapse}button,input,optgroup,select,textarea{font-family:inherit;font-feature-settings:inherit;font-variation-settings:inherit;font-size:100%;font-weight:inherit;line-height:inherit;letter-spacing:inherit;color:inherit;margin:0;padding:0}button,select{text-transform:none}button,input:where([type=button]),input:where([type=reset]),input:where([type=submit]){-webkit-appearance:button;background-color:transparent;background-image:none}:-moz-focusring{outline:auto}:-moz-ui-invalid{box-shadow:none}progress{vertical-align:baseline}::-webkit-inner-spin-button,::-webkit-outer-spin-button{height:auto}[type=search]{-webkit-appearance:textfield;outline-offset:-2px}::-webkit-search-decoration{-webkit-appearance:none}::-webkit-file-upload-button{-webkit-appearance:button;font:inherit}summary{display:list-item}blockquote,dd,dl,figure,h1,h2,h3,h4,h5,h6,hr,p,pre{margin:0}fieldset{margin:0}fieldset,legend{padding:0}menu,ol,ul{list-style:none;margin:0;padding:0}dialog{padding:0}textarea{resize:vertical}input::-moz-placeholder,textarea::-moz-placeholder{opacity:1;color:#9ca3af}input::placeholder,textarea::placeholder{opacity:1;color:#9ca3af}[role=button],button{cursor:pointer}:disabled{cursor:default}audio,canvas,embed,iframe,img,object,svg,video{display:block;vertical-align:middle}img,video{max-width:100%;height:auto}[hidden]:where(:not([hidden=until-found])){display:none}input:where(:not([type])),input:where([type=date]),input:where([type=datetime-local]),input:where([type=email]),input:where([type=month]),input:where([type=number]),input:where([type=password]),input:where([type=search]),input:where([type=tel]),input:where([type=text]),input:where([type=time]),input:where([type=url]),input:where([type=week]),select,select:where([multiple]),textarea{-webkit-appearance:none;-moz-appearance:none;appearance:none;background-color:#fff;border-color:#6b7280;border-width:1px;border-radius:0;padding:.5rem .75rem;font-size:1rem;line-height:1.5rem;--tw-shadow:0 0 #0000}input:where(:not([type])):focus,input:where([type=date]):focus,input:where([type=datetime-local]):focus,input:where([type=email]):focus,input:where([type=month]):focus,input:where([type=number]):focus,input:where([type=password]):focus,input:where([type=search]):focus,input:where([type=tel]):focus,input:where([type=text]):focus,input:where([type=time]):focus,input:where([type=url]):focus,input:where([type=week]):focus,select:focus,select:where([multiple]):focus,textarea:focus{outline:2px solid transparent;outline-offset:2px;--tw-ring-inset:var(--tw-empty,/*!*/ /*!*/);--tw-ring-offset-width:0px;--tw-ring-offset-color:#fff;--tw-ring-color:#2563eb;--tw-ring-offset-shadow:var(--tw-ring-inset) 0 0 0 var(--tw-ring-offset-width) var(--tw-ring-offset-color);--tw-ring-shadow:var(--tw-ring-inset) 0 0 0 calc(1px + var(--tw-ring-offset-width)) var(--tw-ring-color);box-shadow:var(--tw-ring-offset-shadow),var(--tw-ring-shadow),var(--tw-shadow);border-color:#2563eb}input::-moz-placeholder,textarea::-moz-placeholder{color:#6b7280;opacity:1}input::placeholder,textarea::placeholder{color:#6b7280;opacity:1}::-webkit-datetime-edit-fields-wrapper{padding:0}::-webkit-date-and-time-value{min-height:1.5em;text-align:inherit}::-webkit-datetime-edit{display:inline-flex}::-webkit-datetime-edit,::-webkit-datetime-edit-day-field,::-webkit-datetime-edit-hour-field,::-webkit-datetime-edit-meridiem-field,::-webkit-datetime-edit-millisecond-field,::-webkit-datetime-edit-minute-field,::-webkit-datetime-edit-month-field,::-webkit-datetime-edit-second-field,::-webkit-datetime-edit-year-field{padding-top:0;padding-bottom:0}select{background-image:url("data:image/svg+xml;charset=utf-8,%3Csvg xmlns='http://www.w3.org/2000/svg' fill='none' viewBox='0 0 20 20'%3E%3Cpath Line truncated