fix(ui): user-test round 4 — five browser-reported control defects
Every one of these was silent at the code level and loud in a real
browser; each fix carries its own tripwire (render pin, unit pin, or
CSP-safe rewrite) so the class cannot quietly return.
1. Theme picker dead since the CSP migration (eb57b720): the Appearance
panel's theme buttons emitted `@click="selectTheme(opt.Name)"` as
LITERAL text (templ gotcha #1 — quoted attribute values are never
interpolated; `opt` is a Go loop var), so Alpine threw "Undefined
variable: opt" on every click and no PUT /api/auth/theme ever fired.
The wood-paneling sibling always used the correct expression form,
which is why the panel half-worked. Fixed to the interpolated form;
TestThemePickerHandlersAreInterpolated pins that real theme names
reach the HTML and the raw identifier never does.
2. Filter-builder op dropdown "does nothing": the field ingest
hardcoded `ops: []` into every field's meta while only mirroring the
ops into the global label registry — opsFor() returned [] for EVERY
field, so the op menu rendered zero items: an invisible menu, no
console error (user tried author/publisher/title/subtitle, all
equally dead). FieldMeta.ops is now the wire's op objects, opsFor()
is a standalone exported helper, and opsForField unit tests pin the
round-trip. Verified live: the field menu opens/closes while the op
menu stayed shut, both with identical wiring — the difference was
the data, not the wiring.
3. AND/OR connective chip dead: the chip carried an `if` STATEMENT in
the Alpine attribute (`@click="if (row.chipClickable) ..."`) which
the CSP build's evaluator rejects as a statement — the whole
expression silently never ran. Moved the clickability check into a
toggleConnective(row) component method; the attribute is now a plain
method call.
4. Pencil vs card navigation race: navigateToCollection guarded with
`event.target instanceof HTMLElement`, which is FALSE for the
pencil glyph's SVGElement — a click landing on the glyph sailed past
the guard and navigated while the htmx edit-modal request still
fired (the reported "modal flashes, then the builder page"). The
guard now uses target.closest("button") (works on SVGElement) and
takes $event explicitly instead of the deprecated window.event.
.icon-btn is already a 36px square, so no hit-area change needed.
5. Add Items modal under the sidebar + taller than the window: the
picker overlay sat at z-50 UNDER the app-sidebar's z-60 (its left
edge rendered beneath the nav), and the card had no height bound —
header + tabs + filters + grid + footer overflow short windows with
the footer unreachable (fixed overlay, no page scroll). The picker
and create-modal overlays move to z-[65], both confirm dialogs to
z-[70], and the picker card is now a flex column capped at
max-h-[85vh] whose grids flex-fill (they grow on tall windows,
shrink on short ones). The ladder is documented at .app-sidebar in
input.css: sidebar 60 / overlays 65 / confirm 70 / toasts 9999.
Found by clicking every control the way a user does (panel clicks +
computed-style reads + screenshots) after the previous sweep trusted
DOM-text snapshots, which show hidden menus' text and cannot see
occlusion, stacking, or geometry at all.
This commit is contained in:
1 parent
8aec80cbb7
commit
d5dbaa48ea
15 files changed
+299
-177
No files matched your search
@@ -130,3 +130,38 @@ func TestLibrarySwitcherExcludesPodcasts(t *testing.T) {
|
||||
t.Error("switcher missing the books library")
|
||||
}
|
||||
}
|
||||
|
||||
// The Appearance panel's theme buttons interpolate their click handlers
|
||||
// from Go loop vars. The CSP-build migration (eb57b720) shipped
|
||||
// `@click="selectTheme(opt.Name)"` as LITERAL text (templ gotcha #1:
|
||||
// quoted attribute values are never interpolated), so Alpine threw
|
||||
// "Undefined variable: opt" on every theme click and themes were
|
||||
// unchangeable until the user report, 2026-10-31. The wood-paneling
|
||||
// sibling always had the correct expression form, which is why the
|
||||
// panel half-worked. Pin both halves: handlers must carry real theme
|
||||
// names, and the raw Go identifier must never reach the HTML.
|
||||
func TestThemePickerHandlersAreInterpolated(t *testing.T) {
|
||||
var b strings.Builder
|
||||
user := User{ID: "u1", Username: "testuser", Role: "admin", Theme: "tokyo-night", ShowPodcastsNav: true}
|
||||
if err := Header(user, "/collections").Render(context.Background(), &b); err != nil {
|
||||
t.Fatalf("Header: %v", err)
|
||||
}
|
||||
out := b.String()
|
||||
// templ escapes `'` as ' inside attribute values; the HTML parser
|
||||
// decodes entities before Alpine evaluates, so normalize for matching.
|
||||
decoded := strings.ReplaceAll(out, "'", "'")
|
||||
if strings.Contains(out, "selectTheme(opt.Name)") {
|
||||
t.Error("theme buttons leaked the raw Go loop var into the click handler (themes unchangeable)")
|
||||
}
|
||||
if strings.Contains(out, "changeWoodPaneling(w.Name)") {
|
||||
t.Error("wood buttons leaked the raw Go loop var into the click handler")
|
||||
}
|
||||
// At least the SSR'd current theme and one wood option must appear
|
||||
// as real string-literal arguments.
|
||||
if !strings.Contains(decoded, "selectTheme('tokyo-night')") {
|
||||
t.Error("theme buttons missing the interpolated current-theme handler")
|
||||
}
|
||||
if !strings.Contains(decoded, "changeWoodPaneling('none')") {
|
||||
t.Error("wood buttons missing the interpolated handler")
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user