test: add comprehensive test coverage for dashboard
Phase 11 - Unit and Integration Tests Service Layer Tests (dashboard_service_test.go): - Test filterHiddenCollections with multiple scenarios - Test reorderCollections with custom orders - Test sortByPriority sorting logic - All 6 tests passing Handler Tests (dashboard_test.go): - Test BuildSections type conversion - Test textToString helper function - Test getViewAllURL mapping - All 7 tests passing Preview Tests (collections_preview_test.go): - Test preview endpoint validation - Test limit validation - Test rule validation - 6 test scenarios Integration Tests (dashboard_integration_test.go): - Test GET /api/dashboard/sections end-to-end - Test PUT /api/dashboard/preferences - Test POST /api/dashboard/restore-system-collection - Test authentication and validation - 9 test scenarios total Part of Carousel Dashboard Plan completion
This commit is contained in:
@@ -0,0 +1,279 @@
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"encoding/json"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"testing"
|
||||
|
||||
"bookhoard/internal/database"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
"github.com/labstack/echo/v4"
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestPreviewCollection_NoAuth(t *testing.T) {
|
||||
e := echo.New()
|
||||
handler := &CollectionHandler{}
|
||||
|
||||
reqBody := map[string]interface{}{
|
||||
"library_id": uuid.New().String(),
|
||||
"rules": []map[string]interface{}{},
|
||||
"manual_book_ids": []string{},
|
||||
"limit": 20,
|
||||
}
|
||||
body, _ := json.Marshal(reqBody)
|
||||
|
||||
req := httptest.NewRequest("POST", "/api/collections/preview", bytes.NewBuffer(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
rec := httptest.NewRecorder()
|
||||
|
||||
c := e.NewContext(req, rec)
|
||||
|
||||
err := handler.PreviewCollection(c)
|
||||
assert.NoError(t, err)
|
||||
|
||||
assert.Equal(t, http.StatusUnauthorized, rec.Code)
|
||||
}
|
||||
|
||||
func TestPreviewCollection_MissingLibraryID(t *testing.T) {
|
||||
e := echo.New()
|
||||
handler := &CollectionHandler{}
|
||||
|
||||
reqBody := map[string]interface{}{
|
||||
"library_id": "",
|
||||
"rules": []map[string]interface{}{},
|
||||
"manual_book_ids": []string{},
|
||||
"limit": 20,
|
||||
}
|
||||
body, _ := json.Marshal(reqBody)
|
||||
|
||||
req := httptest.NewRequest("POST", "/api/collections/preview", bytes.NewBuffer(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
rec := httptest.NewRecorder()
|
||||
|
||||
// Mock user (would normally come from middleware)
|
||||
user := database.Users{
|
||||
ID: pgtype.UUID{Bytes: uuid.New(), Valid: true},
|
||||
}
|
||||
c := e.NewContext(req, rec)
|
||||
c.Set("user", user)
|
||||
|
||||
err := handler.PreviewCollection(c)
|
||||
assert.NoError(t, err)
|
||||
|
||||
assert.Equal(t, http.StatusBadRequest, rec.Code)
|
||||
}
|
||||
|
||||
func TestPreviewCollection_InvalidLibraryID(t *testing.T) {
|
||||
e := echo.New()
|
||||
handler := &CollectionHandler{}
|
||||
|
||||
reqBody := map[string]interface{}{
|
||||
"library_id": "invalid-uuid",
|
||||
"rules": []map[string]interface{}{},
|
||||
"manual_book_ids": []string{},
|
||||
"limit": 20,
|
||||
}
|
||||
body, _ := json.Marshal(reqBody)
|
||||
|
||||
req := httptest.NewRequest("POST", "/api/collections/preview", bytes.NewBuffer(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
rec := httptest.NewRecorder()
|
||||
|
||||
// Mock user
|
||||
user := database.Users{
|
||||
ID: pgtype.UUID{Bytes: uuid.New(), Valid: true},
|
||||
}
|
||||
c := e.NewContext(req, rec)
|
||||
c.Set("user", user)
|
||||
|
||||
err := handler.PreviewCollection(c)
|
||||
assert.NoError(t, err)
|
||||
|
||||
assert.Equal(t, http.StatusBadRequest, rec.Code)
|
||||
}
|
||||
|
||||
func TestPreviewCollection_LimitValidation(t *testing.T) {
|
||||
e := echo.New()
|
||||
handler := &CollectionHandler{}
|
||||
libraryID := uuid.New()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
limit int
|
||||
expectedStatus int
|
||||
}{
|
||||
{
|
||||
name: "valid limit 10",
|
||||
limit: 10,
|
||||
expectedStatus: http.StatusBadRequest, // No actual library, so will return error
|
||||
},
|
||||
{
|
||||
name: "valid limit 20",
|
||||
limit: 20,
|
||||
expectedStatus: http.StatusBadRequest, // No actual library, so will return error
|
||||
},
|
||||
{
|
||||
name: "limit too high (101)",
|
||||
limit: 101,
|
||||
expectedStatus: http.StatusBadRequest, // Limit validation
|
||||
},
|
||||
{
|
||||
name: "limit zero",
|
||||
limit: 0,
|
||||
expectedStatus: http.StatusBadRequest, // Should default to 20, but library doesn't exist
|
||||
},
|
||||
{
|
||||
name: "negative limit",
|
||||
limit: -5,
|
||||
expectedStatus: http.StatusBadRequest, // No actual library
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
reqBody := map[string]interface{}{
|
||||
"library_id": libraryID.String(),
|
||||
"rules": []map[string]interface{}{},
|
||||
"manual_book_ids": []string{},
|
||||
"limit": tt.limit,
|
||||
}
|
||||
body, _ := json.Marshal(reqBody)
|
||||
|
||||
req := httptest.NewRequest("POST", "/api/collections/preview", bytes.NewBuffer(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
rec := httptest.NewRecorder()
|
||||
|
||||
// Mock user
|
||||
user := database.Users{
|
||||
ID: pgtype.UUID{Bytes: uuid.New(), Valid: true},
|
||||
}
|
||||
c := e.NewContext(req, rec)
|
||||
c.Set("user", user)
|
||||
|
||||
err := handler.PreviewCollection(c)
|
||||
require.NoError(t, err)
|
||||
|
||||
assert.Equal(t, tt.expectedStatus, rec.Code)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestPreviewCollection_RuleValidation(t *testing.T) {
|
||||
e := echo.New()
|
||||
handler := &CollectionHandler{}
|
||||
libraryID := uuid.New()
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
rules interface{}
|
||||
expectedStatus int
|
||||
}{
|
||||
{
|
||||
name: "empty rules array",
|
||||
rules: []map[string]interface{}{},
|
||||
expectedStatus: http.StatusBadRequest, // Library doesn't exist
|
||||
},
|
||||
{
|
||||
name: "valid rule structure",
|
||||
rules: []map[string]interface{}{
|
||||
{
|
||||
"id": "rule1",
|
||||
"field": "genre",
|
||||
"operator": "equals",
|
||||
"value": "Sci-Fi",
|
||||
"priority": 1,
|
||||
},
|
||||
},
|
||||
expectedStatus: http.StatusBadRequest, // Library doesn't exist
|
||||
},
|
||||
{
|
||||
name: "multiple rules",
|
||||
rules: []map[string]interface{}{
|
||||
{
|
||||
"id": "rule1",
|
||||
"field": "genre",
|
||||
"operator": "equals",
|
||||
"value": "Sci-Fi",
|
||||
"priority": 1,
|
||||
},
|
||||
{
|
||||
"id": "rule2",
|
||||
"field": "author",
|
||||
"operator": "contains",
|
||||
"value": "Asimov",
|
||||
"priority": 2,
|
||||
},
|
||||
},
|
||||
expectedStatus: http.StatusBadRequest, // Library doesn't exist
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
reqBody := map[string]interface{}{
|
||||
"library_id": libraryID.String(),
|
||||
"rules": tt.rules,
|
||||
"manual_book_ids": []string{},
|
||||
"limit": 20,
|
||||
}
|
||||
body, _ := json.Marshal(reqBody)
|
||||
|
||||
req := httptest.NewRequest("POST", "/api/collections/preview", bytes.NewBuffer(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
rec := httptest.NewRecorder()
|
||||
|
||||
// Mock user
|
||||
user := database.Users{
|
||||
ID: pgtype.UUID{Bytes: uuid.New(), Valid: true},
|
||||
}
|
||||
c := e.NewContext(req, rec)
|
||||
c.Set("user", user)
|
||||
|
||||
err := handler.PreviewCollection(c)
|
||||
require.NoError(t, err)
|
||||
|
||||
assert.Equal(t, tt.expectedStatus, rec.Code)
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestPreviewCollection_ManualBookSelection(t *testing.T) {
|
||||
e := echo.New()
|
||||
handler := &CollectionHandler{}
|
||||
libraryID := uuid.New()
|
||||
|
||||
reqBody := map[string]interface{}{
|
||||
"library_id": libraryID.String(),
|
||||
"rules": []map[string]interface{}{},
|
||||
"manual_book_ids": []string{
|
||||
uuid.New().String(),
|
||||
uuid.New().String(),
|
||||
uuid.New().String(),
|
||||
},
|
||||
"limit": 20,
|
||||
}
|
||||
body, _ := json.Marshal(reqBody)
|
||||
|
||||
req := httptest.NewRequest("POST", "/api/collections/preview", bytes.NewBuffer(body))
|
||||
req.Header.Set("Content-Type", "application/json")
|
||||
rec := httptest.NewRecorder()
|
||||
|
||||
// Mock user
|
||||
user := database.Users{
|
||||
ID: pgtype.UUID{Bytes: uuid.New(), Valid: true},
|
||||
}
|
||||
c := e.NewContext(req, rec)
|
||||
c.Set("user", user)
|
||||
|
||||
err := handler.PreviewCollection(c)
|
||||
require.NoError(t, err)
|
||||
|
||||
// Should return 400 because library doesn't exist
|
||||
assert.Equal(t, http.StatusBadRequest, rec.Code)
|
||||
}
|
||||
@@ -0,0 +1,182 @@
|
||||
package handlers
|
||||
|
||||
import (
|
||||
"testing"
|
||||
|
||||
"bookhoard/internal/database"
|
||||
"bookhoard/internal/services"
|
||||
|
||||
"github.com/google/uuid"
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
"github.com/stretchr/testify/assert"
|
||||
)
|
||||
|
||||
func TestBuildSections_ConvertsServiceTypesToHandlerTypes(t *testing.T) {
|
||||
itemUUID := uuid.New()
|
||||
|
||||
serviceSections := []services.DashboardSection{
|
||||
{
|
||||
CollectionID: uuid.UUID{},
|
||||
CollectionName: "continue-reading",
|
||||
QueryType: "continue-reading",
|
||||
Priority: 1,
|
||||
IsSystem: true,
|
||||
Title: "Continue Reading",
|
||||
Description: "Books you're currently reading",
|
||||
Icon: "📖",
|
||||
Items: []database.MediaItems{
|
||||
{
|
||||
ID: pgtype.UUID{Bytes: itemUUID, Valid: true},
|
||||
Title: "Test Book",
|
||||
Author: pgtype.Text{String: "Test Author", Valid: true},
|
||||
CoverImagePath: pgtype.Text{String: "/path/to/cover.jpg", Valid: true},
|
||||
},
|
||||
},
|
||||
},
|
||||
{
|
||||
CollectionID: uuid.UUID{},
|
||||
CollectionName: "my-favorites",
|
||||
QueryType: "filter",
|
||||
Priority: 10,
|
||||
IsSystem: false,
|
||||
Title: "My Favorites",
|
||||
Description: "My favorite books",
|
||||
Icon: "⭐",
|
||||
Items: []database.MediaItems{},
|
||||
},
|
||||
}
|
||||
|
||||
result := BuildSections(serviceSections)
|
||||
|
||||
assert.Equal(t, 2, len(result), "should have 2 sections")
|
||||
|
||||
section1 := result[0]
|
||||
assert.Equal(t, "continue-reading", section1.ID, "ID should match")
|
||||
assert.True(t, section1.IsSystem, "IsSystem should be boolean true")
|
||||
assert.Equal(t, "Continue Reading", section1.Title, "Title should be string")
|
||||
assert.Equal(t, "Books you're currently reading", section1.Description, "Description should be string")
|
||||
assert.Equal(t, "📖", section1.Icon, "Icon should be string")
|
||||
assert.Equal(t, 1, section1.Priority, "Priority should be number")
|
||||
assert.Equal(t, "/section/continue-reading", section1.ViewAllURL, "ViewAllURL should match system collection")
|
||||
|
||||
section2 := result[1]
|
||||
assert.Equal(t, "my-favorites", section2.ID)
|
||||
assert.False(t, section2.IsSystem, "IsSystem should be boolean false")
|
||||
assert.Equal(t, "My Favorites", section2.Title)
|
||||
assert.Equal(t, "", section2.ViewAllURL, "ViewAllURL should be empty for user collections")
|
||||
}
|
||||
|
||||
func TestBuildSections_ConvertsItemsCorrectly(t *testing.T) {
|
||||
itemUUID := uuid.New()
|
||||
|
||||
serviceSections := []services.DashboardSection{
|
||||
{
|
||||
CollectionID: uuid.UUID{},
|
||||
CollectionName: "continue-reading",
|
||||
QueryType: "continue-reading",
|
||||
Priority: 1,
|
||||
IsSystem: true,
|
||||
Title: "Continue Reading",
|
||||
Description: "Books you're currently reading",
|
||||
Icon: "📖",
|
||||
Items: []database.MediaItems{
|
||||
{
|
||||
ID: pgtype.UUID{Bytes: itemUUID, Valid: true},
|
||||
Title: "Test Book",
|
||||
Author: pgtype.Text{String: "Test Author", Valid: true},
|
||||
CoverImagePath: pgtype.Text{String: "/path/to/cover.jpg", Valid: true},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
result := BuildSections(serviceSections)
|
||||
|
||||
assert.Equal(t, 1, len(result), "should have 1 section")
|
||||
section := result[0]
|
||||
assert.Equal(t, 1, len(section.Items), "should have 1 item")
|
||||
|
||||
item := section.Items[0]
|
||||
assert.Equal(t, itemUUID.String(), item.MediaItemID, "MediaItemID should match")
|
||||
assert.Equal(t, "Test Book", item.Title, "Title should be string")
|
||||
assert.Equal(t, "Test Author", item.Author, "Author should be string")
|
||||
assert.Equal(t, "/path/to/cover.jpg", item.CoverImagePath, "CoverImagePath should be string")
|
||||
}
|
||||
|
||||
func TestTextToString_Valid(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
input pgtype.Text
|
||||
expected string
|
||||
}{
|
||||
{
|
||||
name: "valid text",
|
||||
input: pgtype.Text{String: "hello", Valid: true},
|
||||
expected: "hello",
|
||||
},
|
||||
{
|
||||
name: "empty text",
|
||||
input: pgtype.Text{String: "", Valid: true},
|
||||
expected: "",
|
||||
},
|
||||
{
|
||||
name: "invalid text",
|
||||
input: pgtype.Text{String: "ignored", Valid: false},
|
||||
expected: "",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
result := textToString(tt.input)
|
||||
assert.Equal(t, tt.expected, result, "textToString result mismatch")
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
func TestGetViewAllURL_SystemCollections(t *testing.T) {
|
||||
tests := []struct {
|
||||
name string
|
||||
collectionName string
|
||||
queryType string
|
||||
expected string
|
||||
}{
|
||||
{
|
||||
name: "continue-reading",
|
||||
collectionName: "continue-reading",
|
||||
queryType: "continue-reading",
|
||||
expected: "/section/continue-reading",
|
||||
},
|
||||
{
|
||||
name: "recently-added",
|
||||
collectionName: "recently-added",
|
||||
queryType: "recently-added",
|
||||
expected: "/section/recently-added",
|
||||
},
|
||||
{
|
||||
name: "recently-read",
|
||||
collectionName: "recently-read",
|
||||
queryType: "recently-read",
|
||||
expected: "/history",
|
||||
},
|
||||
{
|
||||
name: "not-started",
|
||||
collectionName: "not-started",
|
||||
queryType: "not-started",
|
||||
expected: "/section/not-started",
|
||||
},
|
||||
{
|
||||
name: "user collection",
|
||||
collectionName: "my-favorites",
|
||||
queryType: "filter",
|
||||
expected: "",
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
result := getViewAllURL(tt.collectionName, tt.queryType)
|
||||
assert.Equal(t, tt.expected, result, "getViewAllURL mismatch")
|
||||
})
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user