test(server): fixture collisions fixed, stale contract asserts re-anchored, gofmt — suite now fully green

Closes the remaining integration-suite failures (handoff open bug 3), line by line: - Fixture family (the upsert equivalence): tags_filter_test ("Science Fiction" found 1 of 3; "Fantasy" 404'd on zero results), media_item_isbn_test (normalization read back the first case's ISBN everywhere; edge cases saw a nil ISBN; pagination collapsed 5 creates onto 1 row), search_unified_test (its 3 books were actually 1 row + two no-op creates) — all POSTed a constant file_path into one library while CreateMediaItem upserts ON CONFLICT (library_id, file_path). Every fixture now uses unique per-item paths, the suite's universal convention elsewhere. TestTagsFilter confirmed same-family: counts came right with no second bug. - New TestMediaItemCreateDuplicatePath pins the honest-create contract from da13898: 201 for the first create; 200 + duplicate flag + the EXISTING row (never a 201 lie), second payload not overwritten. - library_browse_test: the admin subtest browsed the container's /tmp and required it non-empty — env-coupled (empty /tmp → "was []"). Now browses a self-created t.TempDir with two subdirs and a decoy file, asserting ONLY directories are listed. - series_integration_test: three stale assertions re-anchored to the shipped contracts, each with a ground-truth comment: /dashboard/ sections key identity on the collection NAME (BuildSections ID = CollectionName; the web/app reorder + hidden prefs persist those strings) — the kebab query_type is the storage key and is not exposed; /api/series/books is name-ONLY (the app client and the web SSR page both send name only; library_id is ignored, never validated); /api/series is optional-scope BY DESIGN (GetDistinct- Series: narg IS NULL OR library_id = narg aggregates across libraries when omitted). The former 400-on-missing-library_id expectations asserted validation that never shipped. - gofmt rider on three untouched-in-this-arc test files (dashboard_integration, search, test_helpers). Full suite with -parallel=1: 217 groups pass, zero failures.
2026-10-09 17:11:12 -04:00
1 parent da13898046
commit f24a2d6c22
@@ -77,21 +77,21 @@ type DeviceTestData struct {

 // TestServerSetup manages the lifecycle of a test server with proper resource cleanup
 type TestServerSetup struct {
-	Server          *httptest.Server
-	DB              *database.Queries
-	DBPool          *pgxpool.Pool
-	Config          *config.Config
-	ConnManager     *wsync.ConnectionManager
-	QueueProcessor  *wsync.SyncQueueProcessor
-	ProgressService *wsync.ProgressService
+	Server            *httptest.Server
+	DB                *database.Queries
+	DBPool            *pgxpool.Pool
+	Config            *config.Config
+	ConnManager       *wsync.ConnectionManager
+	QueueProcessor    *wsync.SyncQueueProcessor
+	ProgressService   *wsync.ProgressService
 	AnnotationService *wsync.AnnotationService
-	CleanupCancel   context.CancelFunc
-	QueueCtx        context.Context
-	QueueCancel     context.CancelFunc
-	Token           string
-	RegularToken    string
-	mu              sync.Mutex
-	closed          bool
+	CleanupCancel     context.CancelFunc
+	QueueCtx          context.Context
+	QueueCancel       context.CancelFunc
+	Token             string
+	RegularToken      string
+	mu                sync.Mutex
+	closed            bool
 }

 // Close cleans up all resources in the correct order
@@ -539,35 +539,35 @@ func setupTestServer(t *testing.T) *TestServerSetup {

 	// Setup routes using router package
 	routerConfig := &router.Config{
-		Echo:                  e,
-		Queries:               queries,
-		Cfg:                   cfg,
-		DBPool:                dbPool,
-		AuthHandler:           authHandler,
-		LibraryHandler:        libraryHandler,
-		DeviceHandler:         deviceHandler,
-		MediaHandler:          mediaHandler,
-		MatchingHandler:       matchingHandler,
-		KOReaderHandler:       koreaderHandler,
-		WSHandler:             wsHandler,
-		ConflictHandler:       conflictHandler,
-		AnalyticsHandler:      analyticsHandler,
-		QueueHandler:          queueHandler,
-		SystemSettingsHandler: systemSettingsHandler,
+		Echo:                    e,
+		Queries:                 queries,
+		Cfg:                     cfg,
+		DBPool:                  dbPool,
+		AuthHandler:             authHandler,
+		LibraryHandler:          libraryHandler,
+		DeviceHandler:           deviceHandler,
+		MediaHandler:            mediaHandler,
+		MatchingHandler:         matchingHandler,
+		KOReaderHandler:         koreaderHandler,
+		WSHandler:               wsHandler,
+		ConflictHandler:         conflictHandler,
+		AnalyticsHandler:        analyticsHandler,
+		QueueHandler:            queueHandler,
+		SystemSettingsHandler:   systemSettingsHandler,
 		ProcessingIssuesHandler: processingIssuesHandler,
-		CollectionHandler:     collectionHandler,
-		FiltersHandler:        filtersHandler,
-		DashboardHandler:      dashboardHandler,
-		DashboardService:      dashboardService,
-		SeriesHandler:         seriesHandler,
-		OPDSHandler:           opdsHandler,
-		JobsHandler:           jobsHandler,
-		ConnManager:           connManager,
-		QueueProcessor:        queueProcessor,
-		ProgressService:       progressService,
-		AnnotationService:     annotationService,
-		DeviceAuthMiddleware:  deviceAuthMiddleware,
-		LoginTracker:          loginAttemptTracker,
+		CollectionHandler:       collectionHandler,
+		FiltersHandler:          filtersHandler,
+		DashboardHandler:        dashboardHandler,
+		DashboardService:        dashboardService,
+		SeriesHandler:           seriesHandler,
+		OPDSHandler:             opdsHandler,
+		JobsHandler:             jobsHandler,
+		ConnManager:             connManager,
+		QueueProcessor:          queueProcessor,
+		ProgressService:         progressService,
+		AnnotationService:       annotationService,
+		DeviceAuthMiddleware:    deviceAuthMiddleware,
+		LoginTracker:            loginAttemptTracker,
 		// RegisterRoutes dereferences Settings for the auth rate limit;
 		// the main binary wires database.NewSettingsRegistry(queries) —
 		// the test harness must too or route registration nil-panics.