Bookhoard/bookhoard
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 12 Wiki Activity

test: improve test isolation and setup management

Browse Source 
Add Token and RegularToken fields to TestServerSetup for pre-authenticated
access. Update setupTestServer to create fresh users with valid tokens at
initialization time. Simplify createTestMediaItemID to use setup.Token.
Remove loginTestUser, loginRegularUser, loginAdminUser functions in favor
of setup.Token/setup.RegularToken. Update createTestUserOnce and
getTestUserID/getRegularUserID to be idempotent. Update all test files to
use setup.Token instead of calling login helpers.
This commit is contained in:
john-okeefe
2026-02-22 01:57:22 -05:00
parent 9a09161f24
commit f54508e4dd
16 changed files with 819 additions and 793 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cmd/server/tests/device_cap_test.go
+6 -10
View File
@@ -17,11 +17,7 @@ import (
// TestUpdateUserMaxDevices tests the admin endpoint for updating user device cap
func TestUpdateUserMaxDevices(t *testing.T) {
setup := setupTestServer(t)
// Create test user with admin role
loginTestUser(t, setup.Server, setup.DB)
adminUserID := getTestUserID(t, setup.DB)
adminToken := getAdminToken(t, setup.Server, adminUserID)
adminToken := setup.Token
// Create a test user
userID := createTestUserForMaxDevices(t, setup.Server, adminToken)
@@ -89,7 +85,7 @@ func TestUpdateUserMaxDevicesValidation(t *testing.T) {
setup := setupTestServer(t)
// Create admin user and get token
adminToken := loginTestUser(t, setup.Server, setup.DB)
adminToken := setup.Token
createAdminUser(t, setup.Server, adminToken)
adminUserID := getTestUserID(t, setup.DB)
adminToken = getAdminToken(t, setup.Server, adminUserID)
@@ -150,7 +146,7 @@ func TestUpdateUserMaxDevicesAuth(t *testing.T) {
setup := setupTestServer(t)
// Create admin user
adminToken := loginTestUser(t, setup.Server, setup.DB)
adminToken := setup.Token
createAdminUser(t, setup.Server, adminToken)
adminUserID := getTestUserID(t, setup.DB)
adminToken = getAdminToken(t, setup.Server, adminUserID)
@@ -205,7 +201,7 @@ func TestUpdateUserMaxDevicesNonExistentUser(t *testing.T) {
setup := setupTestServer(t)
// Create admin user
adminToken := loginTestUser(t, setup.Server, setup.DB)
adminToken := setup.Token
createAdminUser(t, setup.Server, adminToken)
adminUserID := getTestUserID(t, setup.DB)
adminToken = getAdminToken(t, setup.Server, adminUserID)
@@ -236,7 +232,7 @@ func TestUpdateUserMaxDevicesMissingUserID(t *testing.T) {
setup := setupTestServer(t)
// Create admin user
adminToken := loginTestUser(t, setup.Server, setup.DB)
adminToken := setup.Token
createAdminUser(t, setup.Server, adminToken)
adminUserID := getTestUserID(t, setup.DB)
adminToken = getAdminToken(t, setup.Server, adminUserID)
@@ -264,7 +260,7 @@ func TestListUsersIncludesMaxDevices(t *testing.T) {
setup := setupTestServer(t)
// Create admin user
adminToken := loginTestUser(t, setup.Server, setup.DB)
adminToken := setup.Token
createAdminUser(t, setup.Server, adminToken)
adminUserID := getTestUserID(t, setup.DB)
adminToken = getAdminToken(t, setup.Server, adminUserID)