From f60f85012661401f43665a4c15b7d2eb8c6f653a Mon Sep 17 00:00:00 2001 From: John O'Keefe Date: Sun, 1 Feb 2026 00:40:19 -0500 Subject: [PATCH] fix(docs): accurately document limitations after code verification MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Verified each limitation against actual code: Rule Testing: - ✅ Backend rules engine exists - ✅ UI for creating rules exists - ❌ Missing: Preview/test function to show matching books Bulk Operations: - ✅ Backend supports bulk add (book_ids array) - ❌ Frontend searchBooks() is placeholder - ❌ Frontend multi-select not implemented - ❌ No bulk remove endpoint or UI Collection Search: - ✅ Backend has filtered search endpoint - ✅ Backend has fuzzy search with word_similarity - ❌ Collections UI doesn't use search endpoints - ❌ No search bar in collection detail view Real-time Collection Updates: - ✅ WebSocket infrastructure exists - ✅ Broadcasts for progress/conflicts work - ❌ No collection change events - ❌ Collections UI doesn't use WebSocket This replaces vague limitations with specific, verified gaps. --- PHASE_9_COMPLETION.md | 33 +++++++++++++++++++++++++++++---- 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/PHASE_9_COMPLETION.md b/PHASE_9_COMPLETION.md index 1a499b2..f56f588 100644 --- a/PHASE_9_COMPLETION.md +++ b/PHASE_9_COMPLETION.md @@ -239,10 +239,35 @@ ## 📝 Known Limitations & Future Enhancements ### Current Limitations -1. **Rule Testing**: Collection rules preview not yet implemented -2. **Bulk Operations**: Batch book operations not yet available -3. **Collection Search**: Search not integrated into collections UI (search exists globally) -4. **Real-time Collection Updates**: WebSocket exists but not yet integrated into collection views +1. **Rule Testing Preview**: Collection rules can be created/saved but there's no "test" or "preview" button to see which books would match before activating + - Backend rules engine exists (`internal/services/collection_service.go`) + - UI for creating rules exists (`templates/collection_rules.templ`) + - Missing: Preview/test function to show matching books + +2. **Bulk Add UI Incomplete**: Backend supports adding multiple books at once (`POST /api/collections/:id/books` with `book_ids[]` array), but frontend UI is incomplete + - ✅ Backend: `AddBooks()` accepts array of book IDs + - ❌ Frontend: `searchBooks()` is placeholder ("Book search coming soon!") + - ❌ Frontend: `selectedBooks` Set referenced but not implemented + - Missing: Multi-select interface for adding multiple books + +3. **Collection-Specific Search**: Global search exists (`/api/media-items/search`) but not integrated into collections UI + - ✅ Backend: Filtered search exists (`/api/media-items/filtered` with author_filter, genre_filter, etc.) + - ✅ Backend: Fuzzy search with word_similarity + - ❌ Frontend: Collections UI doesn't wire up to search endpoints + - Missing: Search/filter bar within collection detail view + +4. **Real-time Collection Updates**: WebSocket infrastructure exists but collections don't auto-update when books are added/removed from other views + - ✅ Backend: WebSocket manager (`internal/sync/websocket.go`) + - ✅ Backend: Broadcast for progress, conflicts, sync events + - ❌ Frontend: Collections UI doesn't use WebSocket + - ❌ Backend: No broadcast when books added/removed from collections + - Missing: Collection change events + WebSocket listener in UI + +5. **Bulk Remove**: Can only remove one book at a time from collections + - ✅ Backend: Remove single book (`DELETE /api/collections/:id/books/:bookId`) + - ❌ Backend: No bulk remove endpoint + - ❌ Frontend: No multi-select for removal + - Missing: Batch delete functionality ### ✅ Already Implemented (Previous Phases) The following features are **COMPLETE** and were implemented in earlier phases: