5 Commits

Include renames

Author	SHA1	Message	Date
John O'Keefe	7bf5697c71	fix(podcasts): library switcher leaked literal "continue" and the podcasts option ... The D13 podcast exclusion (9a148c23) was written as a templ `if !IsBookLibrary(...) { continue }` — but templ markup control flow has NO continue STATEMENT: codegen emitted the word as a TEXT node (visible junk between options on every page's library subbar) and rendered the podcasts option anyway, defeating the exclusion. The real browser sweep caught what every Go/API test structurally cannot: generated markup that renders wrong yet compiles clean. Rewritten as an inverted guard (the idiomatic templ skip). New render pin TestLibrarySwitcherExcludesPodcasts fails on both halves of the original leak — the literal text AND the presence of the podcasts option — so this codegen gotcha class stays tripped-wired.	2026-10-30 20:50:38 -04:00
John O'Keefe	c54430c254	fix(podcasts): code-review pass over the session's UI surfaces ... Findings from the systematic gotcha-class review before the browser pass: - The collection smart editor's Apply derived the collection NAME from document.title — which parses to "Smart Collection", RENAMING the collection on every apply. The server now renders the real name (data-collection-name) and the write path refuses to proceed without it. - TestRenderingPartialsRender pinned the pre-episode-collections empty-state copy ("No books in this collection yet.") — updated to the shipped label ("Nothing in this collection yet."; collections hold episodes now). - The deleted handler-local rule comparators (evaluateRule/ compareValues — removed in item 3.4's single-evaluator refactor) left behind two unit-test files testing the duplicates; deleted. Their semantics remain covered at the service level (TestEvaluateRules_* over FieldMatches/EvaluateRules) and TestTextToString (which actually pins utils.PgTextString) stays. Everything else reviewed clean against the gotcha classes: templ whole-expression attrs, ?={ boolean attrs, JSONArg quoting in x-init/data attrs, Alpine CSP store paths, htmx form-encoding, the " assert escaping, and the aria-label selector contract on the player's reload listener.	2026-10-30 19:38:39 -04:00
John O'Keefe	f6a73ab5aa	feat(unlinked-books): dismiss (ignore) or delete queue entries ... Unidentified sync files used to be stuck: every KOReader re-sync re-queues them, and there was no way to say "this isn't a book" or "I don't want this one on the server". Ignore is the durable dismiss: a new ignored_at column hides the row from the page list, dashboard badge, and per-device API while the sync keeps refreshing its metadata (the upsert never clears the column). A collapsible "Ignored" section lists dismissed rows with Restore and Delete so a misclick is recoverable. Delete is the hard exit — the row is gone, and honestly re-queued if the device syncs that file again (the confirm dialog says so). Actions are page-scoped SSR routes: htmx swaps in the re-rendered section so counts and buckets can never drift from the DB; ownership is row → device → user (admins may act on any row). Integration tests pin the lifecycle (hide everywhere, survive the sync upsert, restore, delete), foreign-user 403s, and the render surface.	2026-10-26 14:58:50 -04:00
John O'Keefe	d74db03cf3	feat(sync): unlinked-books queue — ingest, page route, dashboard banner ... The identification queue for device files the sync cannot match is now live end-to-end. Previously the whole feature was dark: unmatched device files were silently dropped (losing their reading progress), the queue table sat empty by construction, and the page template had no route. - Ingest: the KOReader sync loop, on an unresolvable file, upserts unlinked_books (one row per device + content id; re-syncs bump last_seen_at and refresh device-reported metadata) instead of dropping the file. Schema gains the (device_id, content_id) unique index the upsert needs. - Page: GET /unlinked-books routes the existing page template, listing the caller's own unresolved rows (ListUnresolvedUnlinkedBooksForUser — devices.user_id scoping; no cross-user leakage). - Dashboard banner: a warning card above the shelves, rendered only when the caller's queue is non-empty (hidden-unless-needed), linking to the page. - Resolve flow unchanged and already gated: MatchingHandler.LinkBook verifies device ownership and target-item visibility (403s) and creates the device file alias, so the next sync matches by path. SyncHandler.LinkBook and Handler.LinkBook are unrouted dead handlers — triage candidates, not part of the live flow.	2026-10-18 16:45:48 -04:00
John O'Keefe	cb4e892b10	test(templates): pin the rendering partials — standalone render, OOB markers, empty state	2026-10-18 12:30:55 -04:00