6 Commits

Include renames

Author	SHA1	Message	Date
John O'Keefe	de9e66636a	docs(agents): test-failure triage discipline — suspect the test first, but test edits stay asymmetric ... 2026-10-17 lessons from the hardening session: most test/bruno failures were harness/schema/environment drift (drifted body keys, truncated payloads, container-only paths), found by triaging the test before the server. Codified as: triage order (test schema -> environment -> cheap probe), with the guard against "writing tests to work" — test/contract edits are asymmetric with code fixes: only harness plumbing fixes, additive pin widenings with a changelog entry, or deletions of tests of removed behavior. Pins were green at a known commit; git history arbitrates stale-vs-changed. A right-looking test that fails is prima facie a server bug: stop and flag. contract_pins.md rule 4: narrowing/removing a pinned key requires the user's explicit sign-off — a pin freezing buggy behavior is a ledger, not a license.	2026-10-17 12:39:59 -04:00
John O'Keefe	199d82c613	fix(tests): sync-integration cleanup wiped the shared reading_history table ... sync_integration_test's cleanup ran DELETE FROM reading_history WHERE true — harmless for years while the table sat empty, and a silent stats-data destroyer the moment session capture started feeding it: every suite run erased the shared dev accounts' captured reading (the user's manual flip-through test data included). The cleanup is now scoped: the sync tests' sessions belong to their test-sync users, and deleting those users cascades their rows. Any future table-wide cleanup DELETE is off the table (AGENTS.md test rules updated).	2026-10-14 13:53:51 -04:00
John O'Keefe	5a2c1585ae	refactor(stats): 'Web / unsynced' bucket label → 'Web'; analytics tests isolated from the live reader ... The bucket name read as confusing — 'unsynced' implied data loss when the push is always captured; it only lacks a device credential. The bucket is just 'Web' now (service fallback, stats.ts fallback, panel copy, tests). Also: analytics_test exact-zero assertions (EmptyHistory, NoReadingHistory) ran against testuser, which is a LIVE reader — real sessions accrued on it mid-suite and both flapped. They now run under the fresh regular user, like the stats tests; the 'testuser is a live reader' rule is recorded in AGENTS.md.	2026-10-14 13:24:30 -04:00
John O'Keefe	be10adc24b	docs(agents): stats-build gotchas — end-of-day anchoring (2nd occurrence), dev-DB probe pollution, DeviceID is not always a device	2026-10-14 12:46:54 -04:00
John O'Keefe	8de8883acf	docs(agents): templ attribute-interpolation, settings-cache, collection-routing gotchas ... From the smart-collections build: templ emits quoted attribute values literally (whole-attribute expressions required — the rules page shipped '/api/collections/{ collection.ID }' until proven via request logs); SettingsRegistry only reloads through the settings API (direct SQL writes look ignored); and user collections must never route through the dashboard-section path (query_type='filter' is a schema DEFAULT, not a query type — the 7ce7321 static-detail regression).	2026-10-14 12:00:33 -04:00
John O'Keefe	f42720ac64	docs: retire PROJECT_GUIDELINES.md — library-visibility rule now in AGENTS.md + dev docs ... PROJECT_GUIDELINES.md had drifted out of reality (podman-only rule while the stack runs docker; verifier scripts wired to Makefile targets nobody runs). Trashed it, its two verifier scripts, and the Makefile targets; the rules that still matched reality (docker runtime, schema in place until release, server binary only via Docker, services layer, integration-test pool rules) are absorbed into the new AGENTS.md. The library-visibility family-lens rule now has a real home: - AGENTS.md: the standing rule agents auto-discover (new media endpoints MUST thread the visible-library set; 403, never silently pass; history of the 2026-10-13 leak). - docs/developer/library-visibility.md: the full explanation (helpers, SQL pattern, per-item content gates, series per-library), linked from the developer docs index. Stale doc links updated (docs index, contributing, development).	2026-10-13 20:18:42 -04:00