John O'Keefe
|
8631aa00bf
|
refactor: remove dead code across server, templ pages, and client modules
Deadcode-verified removals (RTA reachability from main, cross-checked
with -test and textual xrefs):
Go server:
- whole files: middleware/transaction.go, middleware/error_handler.go,
middleware/password_validator.go (live registration machinery kept),
handlers/sync.go, sync/offline.go
- unrouted endpoints: auth UpdateUsername/UpdateEmail, timezone
settings handler, OPDS RegisterOPDS, Kobo LibrarySync handler,
ReaderHandler.ShowReader, JSON-data twins on collections/library
- duplicate book-matching handlers (book_matching.go Handler twins,
matching.go MatchingHandler twins), superseded helpers
(router.parseUUID, handlers.ValidateDeviceToken, normalizePath,
userExists, generateLockID)
Templ/client:
- never-routed pages: api_explorer.templ, queue.templ and their
client modules api-explorer.ts, api-explorer-docs.ts, queue.ts
- fully orphaned wrapper modules events.ts, dom.ts
- broken clearSyncQueue (called a nonexistent endpoint) and the
hidden, never-populated sync-queue section on the devices page
- 166+ unused exports demoted to private (knip-verified); ~85 truly
dead declarations removed via tsc noUnusedLocals fixpoint
- stale 'interactive API Explorer' claims dropped from docs
The docs drift-gate package (internal/docs), templ-bound modules
(dashboard, stats, header, index, login, profile*, bookshelf,
collections, toast-error), sqlc-generated code, and web/static are
intentionally untouched.
|
2026-10-25 11:06:08 -04:00 |
|
john-okeefe
|
f87d8fdff5
|
refactor(handlers): Phase 4 - create MatchingHandler for sync operations
- Create MatchingHandler struct with db and connManager fields
- Add NewMatchingHandler constructor
- Add getMatchingService helper method
- Move 12 matching methods from book_matching.go:
* Core matching: QueryBooks, LinkBook, GetUnlinkedBooks, GetBookMatches
* File aliases: GetDeviceFileAliases, CreateDeviceFileAlias, UpdateDeviceFileAlias, DeleteDeviceFileAlias
* Bulk operations: BulkLinkBooks, AutoLinkBooks, GetUnlinkedBookSuggestions
Methods copied (not moved) to maintain backward compatibility.
Duplicates will be removed in Phase 7.
This is Phase 4 of the ebook.go refactoring plan.
|
2026-02-07 19:49:47 -05:00 |
|