3 Commits

Include renames

Author	SHA1	Message	Date
John O'Keefe	3ed852515b	test(helpers): setSystemSettingRestored — leave shared settings as found ... The testuser-experience rule: the suite must leave shared settings exactly as it found them. setSystemSettingRestored snapshots the prior system_settings row, writes through the sanctioned API path (the only one that reloads the settings registry — raw SQL leaves the cache stale), and registers a cleanup restoring what WAS there, never a hardcoded value. setExtractorVersion now rides it, so the ev-pin tests no longer restore scan_extractor_version to a hardcoded 1: a deliberate dev bump of the extractor version survives a suite run instead of being silently cancelled (the live dev server obeys that setting on its next poll and would stop re-extracting parser fixes). The now-redundant explicit t.Cleanup restores are removed from TestExtractorVersionReextract and pinExtractorVersionOne.	2026-10-21 20:24:44 -04:00
John O'Keefe	dd4cf1235c	test: pin scan_extractor_version at the start of ev-sensitive tests ... The extractor/force-rescan tests assert manifest stamps against the default version (1), but the setting lives in the SHARED dev DB — any prior run (or a manual admin-UI bump) can leave it at 2, failing every stamp assertion through no fault of the code. Each ev-sensitive test now pins the setting to 1 at start and restores 1 on cleanup; proven against a deliberately bumped setting (tests pass, row restored).	2026-10-20 22:19:29 -04:00
John O'Keefe	91b0c45dd4	feat(scanner): extractor-version (ev) mechanism — parser fixes reach old rows without a force rescan (faceted plan Phase 10) ... Parser fixes (7e4c97f6, genre model v2) never reached rows ingested under an older parser: the sidecar never changed, so every fingerprint said 'unchanged'. The manifest JSONB now carries the reserved 'ev' stamp — the parser version that produced the item's row. Semantics (all pinned by tests): - ABSENT ev decodes as 1 ('v1-or-unknown'); stamping is truthful-only: create paths + post-extraction stores stamp the setting's current value; deploy-day backfill and the extract-failure guard stay UNSET (a row never claims a version its data can't prove — a mid-backfill bump self-heals next poll); repoint reconciliation preserves the stored ev (stat-only refresh re-extracted nothing). - NEW setting scan_extractor_version (seeded + registry + getter, int default 1, category scanner): a manifest whose ev != the setting re-extracts through the SAME change path (full extraction → updateMediaItemWithMetadata → fresh stamped manifest). Sidecar-less books get an entries-less manifest as their ev home (create: stamped; first-sighting: unset). - Catch-up bounded: evReextractBudgetPerScan=100, atomic (watcher pass can overlap a poll scan), reset per ScanFolders — amortized + resumable across polls; no force rescan, no flood. - Multifile books included: the ev gate rides multifileSidecarChanged's shared ladder; ev-driven manifestChanged drives the editorial apply + stamped re-store. Settings API: the unified GET/PUT /api/system/settings now lists the key (registry-driven, auto-surfaces in the admin UI). Test harness: the registry is now Loaded + wired into the SystemSettingsHandler (main.go parity) — settings writes through the API were 503s before. Verified: unit (ev normalization, budget CAS, GetExtractorVersion cache paths, registry clamping); integration state machine — create-stamp ev=1 → equality skips (corruption probe persists) → wiped scan-state backfills UNSET without re-extract → bump re-extracts ONCE (sidecar value restored, ev=2) → stable (second corruption persists); multifile twin green; adjacent suites (Audiobook, Calibre, CrossLibraryMove, SchemaIdempotency) green; live app restart re-scans 1198 files with 0 changed (deploy-day rule), setting listed at /api/system/settings.	2026-10-20 18:24:08 -04:00