3 Commits

Include renames

Author	SHA1	Message	Date
John O'Keefe	3ed852515b	test(helpers): setSystemSettingRestored — leave shared settings as found ... The testuser-experience rule: the suite must leave shared settings exactly as it found them. setSystemSettingRestored snapshots the prior system_settings row, writes through the sanctioned API path (the only one that reloads the settings registry — raw SQL leaves the cache stale), and registers a cleanup restoring what WAS there, never a hardcoded value. setExtractorVersion now rides it, so the ev-pin tests no longer restore scan_extractor_version to a hardcoded 1: a deliberate dev bump of the extractor version survives a suite run instead of being silently cancelled (the live dev server obeys that setting on its next poll and would stop re-extracting parser fixes). The now-redundant explicit t.Cleanup restores are removed from TestExtractorVersionReextract and pinExtractorVersionOne.	2026-10-21 20:24:44 -04:00
John O'Keefe	dd4cf1235c	test: pin scan_extractor_version at the start of ev-sensitive tests ... The extractor/force-rescan tests assert manifest stamps against the default version (1), but the setting lives in the SHARED dev DB — any prior run (or a manual admin-UI bump) can leave it at 2, failing every stamp assertion through no fault of the code. Each ev-sensitive test now pins the setting to 1 at start and restores 1 on cleanup; proven against a deliberately bumped setting (tests pass, row restored).	2026-10-20 22:19:29 -04:00
John O'Keefe	a42c6d4f75	feat(scanner): force rescan = original scan; feat(filters): the manually-edited filter (faceted plan Phase 13) ... Force rescan contract change (owner-directed): the editorial-keep skip is retired. Force rescan now re-derives EVERY field on EVERY book from all sources — multi-file books included (the folder/zip flows ran the full chain on create and on manifest-flagged edits, but skipped the sidecar apply under force). metadata_overrides is the only protection: ApplyMetadataOverrides re-applies manual values inside the writer, so manual edits survive; everything else re-derives. - A force pass also STAMPS each re-derived book's manifest with the current parser version (success-only — same truthfulness rule as Phase 10) and closes its open processing issues (Phase 11 self-heal). Force rescan and the ev-bump trickle now converge: either leaves the library fully current; the deploy order is bump-first, then Rescan All (documented in the plan and contract_pins). - Single-file force rescan already ran the full chain — unchanged, now pinned. NEW filter field manually_edited ("Manually edited", boolean): cardinality(mi.metadata_overrides) > 0 / = 0. Composed-engine (qf) only — the builder's Book facts group gains it with is true/false; no value menu, no suggestion surface; family lens inherited. Tests: multifile force applies sidecar metadata + stamps + override protection; single-file pin; the filter both directions scoped to the test library; adjacent suites (Audiobook, Calibre, ExtractorVersion, CrossLibraryMove, ProcessingIssues, FilterBuilder, SchemaIdempotency) green. The extractor mechanism itself is untouched — the owner bumps scan_extractor_version manually via the admin UI (plan Phase 13 §3).	2026-10-20 22:05:42 -04:00