Commit Graph
3 Commits
Author SHA1 Message Date
john-okeefe 368c790c67 refactor(tests): enhance test infrastructure with library/collection helpers
- Add LibraryTestData struct to TestDeviceSetup
- Implement CreateLibrary() for proper library creation in tests
- Implement CreateCollection() for test collection support
- Improve test isolation with dedicated library creation

This provides a more robust foundation for integration tests that need
proper library management support.
2026-02-13 20:04:47 -05:00
john-okeefe dfdd5a4685 Phase 0: Fix test infrastructure
- Fix critical bug in createTestUserOnce() (dead code, wrong return type)
- Add test_helpers_db.go with 6 new helper functions
- Impact: All tests can now create users reliably
2026-02-13 17:51:12 -05:00
john-okeefe 2deb845cbc Phase 0: Fix test infrastructure
- Fix critical bug in test_helpers.go (dead code, wrong return type)
- Add test_helpers_db.go with 6 new helper functions:
  * verifyDeviceCreated, verifyDeviceDeleted
  * verifyUserField, verifyMediaItemInDB, verifyMediaItemDeleted
  * createTestLibraryWithFolder
- Impact: All tests can now create users reliably

- Create Phase 1 example (phase1_example_test.go) demonstrating:
  * Struct-based assertions replacing map[string]interface{}
  * Database verification after mutations
  * Type-safe compile-time error detection
- Impact: Template pattern for remaining 500+ conversions

This work transforms brittle map-based tests into reliable struct-based
assertions with database verification, preventing silent API changes
and data corruption bugs.
2026-02-13 17:42:02 -05:00