Files
john-okeefe 0438ec4625 refactor(middleware): fix type signatures for Echo v5 compatibility
Update all middleware functions to use *echo.Context (pointer) instead of echo.Context (value) as required by Echo v5.

Changes in device_auth.go:
- Update DeviceAuthMiddleware() signature (line 38)
- Update validateDeviceAuth() signature (line 170)
- Update RequireDeviceAuth() signature (line 212)

Changes in error_handler.go:
- Update RespondWithError() signature (line 44)
- Update RespondWithHTTPError() signature (line 69)
- Update WrapHandler() to accept *echo.Context (line 82)
- Fix context passing in WrapHandler() (c is already pointer)

Changes in rate_limiter.go:
- Update RateLimiterMiddleware() signature (line 102)

Changes in request_tracing.go:
- Update RequestTracingMiddleware() signature (line 48)
- Fix Response() dereference for v5 API (line 264)
  - Use *c.Response() to get http.ResponseWriter

Changes in security.go:
- Update SecurityHeadersMiddleware() signature (line 14)

Changes in device_auth_test.go:
- Update test helper signatures

Changes in middleware_test.go:
- Remove unused import

All middleware now properly implements Echo v5's pointer-based context pattern.
2026-03-06 14:00:05 -05:00

124 lines
2.6 KiB
Go

package middleware
import (
"net/http"
"sync"
"time"
"github.com/labstack/echo/v5"
)
// RateLimiterConfig defines rate limiting configuration
type RateLimiterConfig struct {
Enabled bool
RequestsPerMinute int
CleanupInterval time.Duration
}
// DefaultRateLimiterConfig returns sensible defaults
func DefaultRateLimiterConfig() RateLimiterConfig {
return RateLimiterConfig{
Enabled: true,
RequestsPerMinute: 10,
CleanupInterval: 5 * time.Minute,
}
}
// RateLimiter tracks request counts per IP
type RateLimiter struct {
mu sync.RWMutex
requests map[string][]time.Time
config RateLimiterConfig
}
// NewRateLimiter creates a new rate limiter
func NewRateLimiter(config RateLimiterConfig) *RateLimiter {
rl := &RateLimiter{
requests: make(map[string][]time.Time),
config: config,
}
// Start cleanup goroutine
go rl.cleanup()
return rl
}
// cleanup removes old request records
func (rl *RateLimiter) cleanup() {
ticker := time.NewTicker(rl.config.CleanupInterval)
defer ticker.Stop()
for range ticker.C {
rl.mu.Lock()
now := time.Now()
for ip, requests := range rl.requests {
// Remove requests older than 1 minute
var valid []time.Time
for _, reqTime := range requests {
if now.Sub(reqTime) < time.Minute {
valid = append(valid, reqTime)
}
}
if len(valid) == 0 {
delete(rl.requests, ip)
} else {
rl.requests[ip] = valid
}
}
rl.mu.Unlock()
}
}
// Allow checks if a request from the given IP should be allowed
func (rl *RateLimiter) Allow(ip string) bool {
rl.mu.Lock()
defer rl.mu.Unlock()
now := time.Now()
// Clean old requests for this IP
var valid []time.Time
for _, reqTime := range rl.requests[ip] {
if now.Sub(reqTime) < time.Minute {
valid = append(valid, reqTime)
}
}
rl.requests[ip] = valid
// Check if limit exceeded
if len(rl.requests[ip]) >= rl.config.RequestsPerMinute {
return false
}
// Add this request
rl.requests[ip] = append(rl.requests[ip], now)
return true
}
// RateLimiterMiddleware returns echo middleware for rate limiting
func RateLimiterMiddleware(rl *RateLimiter) echo.MiddlewareFunc {
return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c *echo.Context) error {
// If rate limiting is disabled, skip checks
if !rl.config.Enabled {
return next(c)
}
// Get client IP
ip := c.RealIP()
if ip == "" {
ip = c.Request().RemoteAddr
}
if !rl.Allow(ip) {
return c.JSON(http.StatusTooManyRequests, map[string]string{
"error": "too many requests, please try again later",
})
}
return next(c)
}
}
}