Files
bookhoard/web
john-okeefe 8388847ec3 fix: Correct progress indicator pagination data access and improve type safety
BUG FIXES:
1. Fix incorrect property access causing page counter to show wrong totals
   - Changed: reader.pageCalculationResult → reader.pagination
   - The pageCalculationResult property doesn't exist on UniversalReader
   - This caused fallback to metadata.total_pages (299) instead of
     calculated pagination.totalPages (119)

2. Fix non-existent chapterMap property access
   - chapterMap doesn't exist on PaginationData interface
   - Changed to use spineMap which provides the same information
   - Calculate chapter start page from spine.pages[0].pageIndex
   - Calculate chapter pages from spine.pages.length

TYPE SAFETY IMPROVEMENTS:
3. Remove 'as any' type cast for ebook reader
   - Changed: const reader = state.currentReader as any
   - To: const reader = state.currentReader
   - TypeScript already knows the type after type check

4. Remove 'as any' type casts for comic/manga readers
   - Added proper type narrowing with if statement
   - Changed: (state.currentReader as any).currentPage
   - To: reader.currentPage with type guard
   - Improves type safety and enables better IDE autocomplete

IMPACT:
 Page counter shows correct total (119 instead of 299)
 Chapter progress displays accurately
 No TypeScript errors for missing properties
 Better type safety prevents similar bugs in the future
 IDE autocomplete works correctly for reader properties

This fix resolves the pagination data access issues that caused the
page counter to display incorrect totals and improves overall type
safety in the progress indicator component.

Related to: Page counter display, type safety improvements
2026-04-11 00:52:32 -04:00
..