Files
bookhoard/templates/partials_render_test.go
T
John O'Keefe f6a73ab5aa
Release / build-and-push (push) Successful in 3m15s
feat(unlinked-books): dismiss (ignore) or delete queue entries
Unidentified sync files used to be stuck: every KOReader re-sync
re-queues them, and there was no way to say "this isn't a book" or "I
don't want this one on the server".

Ignore is the durable dismiss: a new ignored_at column hides the row
from the page list, dashboard badge, and per-device API while the sync
keeps refreshing its metadata (the upsert never clears the column).
A collapsible "Ignored" section lists dismissed rows with Restore and
Delete so a misclick is recoverable. Delete is the hard exit — the row
is gone, and honestly re-queued if the device syncs that file again
(the confirm dialog says so).

Actions are page-scoped SSR routes: htmx swaps in the re-rendered
section so counts and buckets can never drift from the DB; ownership
is row → device → user (admins may act on any row). Integration tests
pin the lifecycle (hide everywhere, survive the sync upsert, restore,
delete), foreign-user 403s, and the render surface.
2026-10-26 14:58:50 -04:00

109 lines
3.6 KiB
Go

package templates
import (
"context"
"strings"
"testing"
"bookhoard/internal/handlers"
)
// The rendering-ownership partials must render standalone (they are
// fetched by htmx.ajax at runtime) and must never leak templ literal
// expressions into their markup.
func TestRenderingPartialsRender(t *testing.T) {
var b strings.Builder
col := CollectionData{ID: "c1", Name: "Test Shelf", IsSmart: false}
books := []handlers.BookInfo{{MediaItemID: "m1", Title: "A Book", Author: "An Author"}}
if err := CollectionBooksGrid(col, books).Render(context.Background(), &b); err != nil {
t.Fatalf("CollectionBooksGrid: %v", err)
}
out := b.String()
for _, want := range []string{"A Book", `data-media-id="m1"`, "Remove from Collection"} {
if !strings.Contains(out, want) {
t.Errorf("books grid missing %q", want)
}
}
// Empty collection renders the empty state, not a literal loop.
b.Reset()
if err := CollectionBooksGrid(col, nil).Render(context.Background(), &b); err != nil {
t.Fatalf("CollectionBooksGrid empty: %v", err)
}
if !strings.Contains(b.String(), "No books in this collection yet.") {
t.Error("books grid empty state missing")
}
b.Reset()
user := User{ID: "u1", Timezone: "UTC"}
conflicts := []handlers.ConflictDetailResponse{{ID: "cf1", MediaItemTitle: "War and Peace", ConflictType: "progress"}}
if err := ConflictsRefreshFragment(user, conflicts, 3, 1).Render(context.Background(), &b); err != nil {
t.Fatalf("ConflictsRefreshFragment: %v", err)
}
out = b.String()
for _, want := range []string{`id="conflicts-list"`, `id="stats-bar"`, "hx-swap-oob", "Resolve"} {
if !strings.Contains(out, want) {
t.Errorf("conflicts fragment missing %q", want)
}
}
}
// The unlinked-books queue banner renders only when the queue is
// non-empty (hidden-unless-needed).
func TestDashboardUnlinkedBanner(t *testing.T) {
render := func(count int) string {
var b strings.Builder
err := Dashboard(User{ID: "u1"}, nil, nil, nil, "", nil, 0, nil, "", "", count).Render(context.Background(), &b)
if err != nil {
t.Fatalf("render: %v", err)
}
return b.String()
}
if out := render(0); strings.Contains(out, "/unlinked-books") {
t.Error("banner rendered with empty queue")
}
out := render(2)
if !strings.Contains(out, "/unlinked-books") || !strings.Contains(out, "could not be identified") {
t.Error("banner missing with non-empty queue")
}
}
// The unlinked-books page renders queue rows standalone, both buckets.
func TestUnlinkedBooksPageRender(t *testing.T) {
var b strings.Builder
user := User{ID: "u1", Timezone: "UTC"}
books := []UnlinkedBookData{{
ProgressID: "ub1",
DeviceName: "Kobo Clara",
DeviceType: "kobo",
FilePath: "/mnt/onboard/book.epub",
SHA256: "abc123",
TitleFromDevice: "Some Sideloaded Book",
LastSyncTime: "2026-10-18 12:00",
}}
ignored := []UnlinkedBookData{{
ProgressID: "ub2",
DeviceName: "KOReader Phone",
DeviceType: "koreader",
FilePath: "/sdcard/ignored.epub",
SHA256: "def456",
TitleFromDevice: "Some Dismissed Book",
LastSyncTime: "2026-10-18 12:00",
}}
if err := UnlinkedBooks(user, books, ignored).Render(context.Background(), &b); err != nil {
t.Fatalf("render: %v", err)
}
out := b.String()
for _, want := range []string{
"Some Sideloaded Book", "abc123", `data-progress-id="ub1"`, "searchMatches",
// Dismiss/delete actions and the ignored recovery bucket.
"Some Dismissed Book", `hx-post="/unlinked-books/ub1/ignore"`,
`hx-delete="/unlinked-books/ub1"`, `hx-post="/unlinked-books/ub2/unignore"`,
"Ignored (1)",
} {
if !strings.Contains(out, want) {
t.Errorf("unlinked page missing %q", want)
}
}
}