Files
bookhoard/cmd/server/tests/device_test.go
T
john-okeefe 9d32e5a0f0 Add comprehensive integration tests for Phase 2 device management
Test Files Added:
- integration_test.sh: Automated integration test script
  * Tests full user flow: register, login, library creation, scanning
  * Tests device registration and management
  * Color-coded output with pass/fail tracking
  * Generates detailed test results report

- cmd/server/tests/device_test.go: Unit tests for device endpoints
  * TestDeviceRegistrationFlow: Full registration flow test
  * TestListDevices: Device listing functionality
  * TestUpdateDevice: Device settings updates
  * TestDeleteDevice: Device removal
  * TestDeviceAuthentication: Device auth middleware test

- cmd/server/tests/phase1_integration_test.go: Phase 1 integration tests
  * Tests universal progress tracking
  * Tests format group detection
  * Tests progress conversion

Test Coverage:
- Device registration with web-based approval flow
- Device management (list, update, delete)
- Device authentication and token validation
- User authentication and authorization
- Library creation and management
- Scanner integration
- Media items listing

Notes:
- Tests designed to run against live server on localhost:8765
- Integration test script uses bash/curl for endpoint testing
- Device tests require helper functions to be implemented
2026-01-30 16:57:01 -05:00

289 lines
10 KiB
Go

package main
import (
"bookmann/internal/database"
"bytes"
"encoding/json"
"fmt"
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/google/uuid"
"github.com/jackc/pgx/v5/pgtype"
"github.com/stretchr/testify/assert"
)
func TestDeviceRegistrationFlow(t *testing.T) {
_, _, _, ts := setupTestServer(t)
defer ts.Close()
// Step 1: Initiate device registration
regRequest := map[string]interface{}{
"device_name": "Test Kindle Paperwhite",
"device_type": "koreader",
"device_identifier": "kindle-test-hw-id-12345",
}
regBody, _ := json.Marshal(regRequest)
req := httptest.NewRequest("POST", "/api/devices/register", bytes.NewReader(regBody))
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusCreated, rec.Code, "Should initiate device registration")
var regResponse map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &regResponse)
registrationID, ok := regResponse["registration_id"].(string)
assert.True(t, ok, "Should have registration_id")
assert.NotEmpty(t, registrationID, "Registration ID should not be empty")
authURL, ok := regResponse["auth_url"].(string)
assert.True(t, ok, "Should have auth_url")
assert.NotEmpty(t, authURL, "Auth URL should not be empty")
// Step 2: Check registration status (should be pending initially)
statusRequest := map[string]interface{}{
"registration_id": registrationID,
}
statusBody, _ := json.Marshal(statusRequest)
req = httptest.NewRequest("POST", "/api/devices/register/status", bytes.NewReader(statusBody))
req.Header.Set("Content-Type", "application/json")
rec = httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusOK, rec.Code, "Should check registration status")
var statusResponse map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &statusResponse)
status, ok := statusResponse["status"].(string)
assert.True(t, ok, "Should have status")
assert.Equal(t, "pending", status, "Should be pending initially")
// Step 3: Login as user to approve device
loginRequest := map[string]interface{}{
"login": "testuser@example.com",
"password": "testpass123",
}
loginBody, _ := json.Marshal(loginRequest)
req = httptest.NewRequest("POST", "/api/auth/login", bytes.NewReader(loginBody))
req.Header.Set("Content-Type", "application/json")
rec = httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusOK, rec.Code, "Should login successfully")
var loginResponse map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &loginResponse)
token, ok := loginResponse["access_token"].(string)
assert.True(t, ok, "Should have access_token")
// Step 4: Approve the device
req = httptest.NewRequest("GET", fmt.Sprintf("/devices/approve/%s", registrationID), nil)
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", "application/json")
rec = httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusOK, rec.Code, "Should approve device")
// Step 5: Check registration status again (should be approved now)
req = httptest.NewRequest("POST", "/api/devices/register/status", bytes.NewReader(statusBody))
req.Header.Set("Content-Type", "application/json")
rec = httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusOK, rec.Code, "Should check registration status after approval")
var approvedStatus map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &approvedStatus)
status, ok = approvedStatus["status"].(string)
assert.True(t, ok, "Should have status")
assert.Equal(t, "approved", status, "Should be approved after user approval")
authToken, ok := approvedStatus["auth_token"].(string)
assert.True(t, ok, "Should have auth_token after approval")
assert.NotEmpty(t, authToken, "Auth token should not be empty")
}
func TestListDevices(t *testing.T) {
db, _, _, ts := setupTestServer(t)
defer ts.Close()
// Login to get token
token := loginTestUser(t, ts)
// Create a device directly in the database
userID := getTestUserID(t, db)
deviceID := uuid.New()
deviceToken := fmt.Sprintf("dev_%s", uuid.New().String())
_, err := db.CreateDevice(context.Background(), database.CreateDeviceParams{
ID: pgtype.UUID{Bytes: [16]byte(deviceID), Valid: true},
UserID: pgtype.UUID{Bytes: [16]byte(userID), Valid: true},
DeviceName: "Test Device",
DeviceType: "koreader",
DeviceIdentifier: "test-device-123",
AuthToken: deviceToken,
SyncEnabled: pgtype.Bool{Bool: true, Valid: true},
AutoSync: pgtype.Bool{Bool: true, Valid: true},
SyncFrequencyMinutes: pgtype.Int4{Int32: 5, Valid: true},
DeviceMetadata: []byte("{}"),
})
assert.NoError(t, err, "Should create device")
// List devices
req := httptest.NewRequest("GET", "/api/devices", nil)
req.Header.Set("Authorization", "Bearer "+token)
rec := httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusOK, rec.Code, "Should list devices")
var response map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &response)
devices, ok := response["devices"].([]interface{})
assert.True(t, ok, "Should have devices array")
assert.GreaterOrEqual(t, len(devices), 1, "Should have at least one device")
firstDevice := devices[0].(map[string]interface{})
deviceName, ok := firstDevice["device_name"].(string)
assert.True(t, ok, "Should have device_name")
assert.Equal(t, "Test Device", deviceName, "Should match created device name")
}
func TestUpdateDevice(t *testing.T) {
db, _, _, ts := setupTestServer(t)
defer ts.Close()
// Login to get token
token := loginTestUser(t, ts)
// Create a device directly in the database
userID := getTestUserID(t, db)
deviceID := uuid.New()
deviceToken := fmt.Sprintf("dev_%s", uuid.New().String())
_, err := db.CreateDevice(context.Background(), database.CreateDeviceParams{
ID: pgtype.UUID{Bytes: [16]byte(deviceID), Valid: true},
UserID: pgtype.UUID{Bytes: [16]byte(userID), Valid: true},
DeviceName: "Test Device",
DeviceType: "koreader",
DeviceIdentifier: "test-device-123",
AuthToken: deviceToken,
SyncEnabled: pgtype.Bool{Bool: true, Valid: true},
AutoSync: pgtype.Bool{Bool: true, Valid: true},
SyncFrequencyMinutes: pgtype.Int4{Int32: 5, Valid: true},
DeviceMetadata: []byte("{}"),
})
assert.NoError(t, err, "Should create device")
// Update device
updateRequest := map[string]interface{}{
"device_name": "Updated Device Name",
"sync_enabled": false,
"sync_frequency_minutes": int32(10),
}
updateBody, _ := json.Marshal(updateRequest)
req := httptest.NewRequest("PUT", fmt.Sprintf("/api/devices/%s", deviceID.String()), bytes.NewReader(updateBody))
req.Header.Set("Authorization", "Bearer "+token)
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusOK, rec.Code, "Should update device")
var response map[string]interface{}
json.Unmarshal(rec.Body.Bytes(), &response)
assert.True(t, response["device_updated"].(bool), "Should confirm device updated")
device := response["device"].(map[string]interface{})
assert.Equal(t, "Updated Device Name", device["device_name"], "Should have updated name")
assert.Equal(t, false, device["sync_enabled"], "Should be disabled")
assert.Equal(t, int32(10), device["sync_frequency"], "Should have updated frequency")
}
func TestDeleteDevice(t *testing.T) {
db, _, _, ts := setupTestServer(t)
defer ts.Close()
// Login to get token
token := loginTestUser(t, ts)
// Create a device directly in the database
userID := getTestUserID(t, db)
deviceID := uuid.New()
deviceToken := fmt.Sprintf("dev_%s", uuid.New().String())
_, err := db.CreateDevice(context.Background(), database.CreateDeviceParams{
ID: pgtype.UUID{Bytes: [16]byte(deviceID), Valid: true},
UserID: pgtype.UUID{Bytes: [16]byte(userID), Valid: true},
DeviceName: "Test Device",
DeviceType: "koreader",
DeviceIdentifier: "test-device-123",
AuthToken: deviceToken,
SyncEnabled: pgtype.Bool{Bool: true, Valid: true},
AutoSync: pgtype.Bool{Bool: true, Valid: true},
SyncFrequencyMinutes: pgtype.Int4{Int32: 5, Valid: true},
DeviceMetadata: []byte("{}"),
})
assert.NoError(t, err, "Should create device")
// Delete device
req := httptest.NewRequest("DELETE", fmt.Sprintf("/api/devices/%s", deviceID.String()), nil)
req.Header.Set("Authorization", "Bearer "+token)
rec := httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
assert.Equal(t, http.StatusNoContent, rec.Code, "Should delete device")
// Verify device is deleted
_, err = db.GetDevice(context.Background(), pgtype.UUID{Bytes: [16]byte(deviceID), Valid: true})
assert.Error(t, err, "Device should be deleted")
}
func TestDeviceAuthentication(t *testing.T) {
db, _, _, ts := setupTestServer(t)
defer ts.Close()
// Create a device directly in the database
userID := getTestUserID(t, db)
deviceID := uuid.New()
deviceToken := fmt.Sprintf("dev_%s", uuid.New().String())
_, err := db.CreateDevice(context.Background(), database.CreateDeviceParams{
ID: pgtype.UUID{Bytes: [16]byte(deviceID), Valid: true},
UserID: pgtype.UUID{Bytes: [16]byte(userID), Valid: true},
DeviceName: "Test Device",
DeviceType: "koreader",
DeviceIdentifier: "test-device-123",
AuthToken: deviceToken,
SyncEnabled: pgtype.Bool{Bool: true, Valid: true},
AutoSync: pgtype.Bool{Bool: true, Valid: true},
SyncFrequencyMinutes: pgtype.Int4{Int32: 5, Valid: true},
DeviceMetadata: []byte("{}"),
})
assert.NoError(t, err, "Should create device")
// Test device authentication
req := httptest.NewRequest("GET", "/api/devices", nil)
req.Header.Set("Authorization", "Bearer "+deviceToken)
rec := httptest.NewRecorder()
ts.Config.Handler.ServeHTTP(rec, req)
// This should fail because device auth middleware is not applied to /api/devices
// Device auth is for sync endpoints only
assert.Equal(t, http.StatusUnauthorized, rec.Code, "Should require user auth for device management")
}