Files
bookhoard/cmd/server/tests/scan_settings_integration_test.go
T
john-okeefe a6700f73e0 fix(tests): handle all Close() and Decode() errors across integration tests
Replace all unhandled resp.Body.Close() calls throughout the test suite:

- Deferred calls: replace 'defer VAR.Body.Close()' with a closure that explicitly
  discards the error via 'defer func(Body io.ReadCloser) { _ = Body.Close() }(VAR.Body)'
- Immediate calls: replace 'VAR.Body.Close()' with '_ = VAR.Body.Close()'

Replace all unhandled json.NewDecoder(VAR.Body).Decode(&x) calls with error capture
and require.NoError assertion. Files using httptest.ResponseRecorder (collections_preview,
processing_issues) use 'err :=' declaration; suite-style tests (scanner_integration,
dashboard_integration) use s.T() instead of t.
2026-04-21 20:33:05 -04:00

187 lines
5.9 KiB
Go

package main
import (
"bytes"
"encoding/json"
"net/http"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestScanSettings_GetSettings(t *testing.T) {
setup := setupTestServer(t)
t.Run("Get settings as admin", func(t *testing.T) {
token := setup.Token
req, _ := http.NewRequest("GET", setup.Server.URL+"/api/libraries/scan-settings", nil)
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, err := client.Do(req)
require.NoError(t, err)
assert.Equal(t, http.StatusOK, resp.StatusCode)
var response map[string]interface{}
err = json.NewDecoder(resp.Body).Decode(&response)
require.NoError(t, err)
_ = resp.Body.Close()
assert.Contains(t, response, "scan_poll_interval_seconds")
assert.Contains(t, response, "auto_scan_enabled")
// Validate scan_poll_interval_seconds is present and valid (don't hardcode value)
interval, ok := response["scan_poll_interval_seconds"].(float64)
require.True(t, ok, "scan_poll_interval_seconds must be a number")
assert.Greater(t, interval, float64(0), "scan_poll_interval_seconds must be positive")
// Validate auto_scan_enabled is present and a boolean
autoScan, ok := response["auto_scan_enabled"].(bool)
require.True(t, ok, "auto_scan_enabled must be a boolean")
assert.NotNil(t, autoScan, "auto_scan_enabled must not be nil")
})
}
func TestScanSettings_UpdateSettings(t *testing.T) {
setup := setupTestServer(t)
t.Run("Update scan_poll_interval_seconds", func(t *testing.T) {
token := setup.Token
updateReq := map[string]interface{}{
"scan_poll_interval_seconds": 45,
"auto_scan_enabled": true,
}
body, _ := json.Marshal(updateReq)
req, _ := http.NewRequest("PUT", setup.Server.URL+"/api/libraries/scan-settings", bytes.NewBuffer(body))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, err := client.Do(req)
require.NoError(t, err)
assert.Equal(t, http.StatusOK, resp.StatusCode)
var response map[string]interface{}
err = json.NewDecoder(resp.Body).Decode(&response)
require.NoError(t, err)
_ = resp.Body.Close()
assert.Equal(t, float64(45), response["scan_poll_interval_seconds"])
assert.Equal(t, true, response["auto_scan_enabled"])
getReq, _ := http.NewRequest("GET", setup.Server.URL+"/api/libraries/scan-settings", nil)
getReq.Header.Set("Authorization", "Bearer "+token)
getResp, _ := client.Do(getReq)
var getResponse map[string]interface{}
err = json.NewDecoder(getResp.Body).Decode(&getResponse)
require.NoError(t, err)
_ = getResp.Body.Close()
assert.Equal(t, float64(45), getResponse["scan_poll_interval_seconds"])
})
t.Run("Update auto_scan_enabled to false", func(t *testing.T) {
token := setup.Token
updateReq := map[string]interface{}{
"scan_poll_interval_seconds": 30,
"auto_scan_enabled": false,
}
body, _ := json.Marshal(updateReq)
req, _ := http.NewRequest("PUT", setup.Server.URL+"/api/libraries/scan-settings", bytes.NewBuffer(body))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, err := client.Do(req)
require.NoError(t, err)
assert.Equal(t, http.StatusOK, resp.StatusCode)
var response map[string]interface{}
err = json.NewDecoder(resp.Body).Decode(&response)
require.NoError(t, err)
_ = resp.Body.Close()
assert.Equal(t, false, response["auto_scan_enabled"])
})
t.Run("Validation rejects values below minimum", func(t *testing.T) {
token := setup.Token
updateReq := map[string]interface{}{
"scan_poll_interval_seconds": 0,
"auto_scan_enabled": true,
}
body, _ := json.Marshal(updateReq)
req, _ := http.NewRequest("PUT", setup.Server.URL+"/api/libraries/scan-settings", bytes.NewBuffer(body))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, err := client.Do(req)
require.NoError(t, err)
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
})
t.Run("Validation rejects values above maximum", func(t *testing.T) {
token := setup.Token
updateReq := map[string]interface{}{
"scan_poll_interval_seconds": 4000,
"auto_scan_enabled": true,
}
body, _ := json.Marshal(updateReq)
req, _ := http.NewRequest("PUT", setup.Server.URL+"/api/libraries/scan-settings", bytes.NewBuffer(body))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, err := client.Do(req)
require.NoError(t, err)
assert.Equal(t, http.StatusBadRequest, resp.StatusCode)
})
}
func TestScanSettings_RequireAdmin(t *testing.T) {
setup := setupTestServer(t)
t.Run("Get settings without auth returns 401", func(t *testing.T) {
req, _ := http.NewRequest("GET", setup.Server.URL+"/api/libraries/scan-settings", nil)
client := &http.Client{}
resp, _ := client.Do(req)
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
})
t.Run("Get settings as non-admin returns 403", func(t *testing.T) {
token := setup.RegularToken
req, _ := http.NewRequest("GET", setup.Server.URL+"/api/libraries/scan-settings", nil)
req.Header.Set("Authorization", "Bearer "+token)
client := &http.Client{}
resp, _ := client.Do(req)
assert.Equal(t, http.StatusForbidden, resp.StatusCode)
})
t.Run("Update settings without auth returns 401", func(t *testing.T) {
updateReq := map[string]interface{}{
"scan_poll_interval_seconds": 30,
"auto_scan_enabled": true,
}
body, _ := json.Marshal(updateReq)
req, _ := http.NewRequest("PUT", setup.Server.URL+"/api/libraries/scan-settings", bytes.NewBuffer(body))
req.Header.Set("Content-Type", "application/json")
client := &http.Client{}
resp, _ := client.Do(req)
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
})
}