Fix nil pointer panics in integration tests by initializing the
four refactored handlers (MediaHandler, SearchHandler, MatchingHandler,
CollectionHandler) that were added during Phase 6 refactoring but
never added to the test setup.
These handlers were properly instantiated in cmd/server/main.go
(commit 9fd8a39) but were missing from cmd/server/tests/test_helpers.go,
causing panics when tests tried to use /api/collections and /api/media-items
endpoints.
Changes:
- Create worker with 3 concurrent workers
- Initialize CollectionHandler with queries and connManager
- Initialize MediaHandler with queries and worker
- Initialize SearchHandler with queries
- Initialize MatchingHandler with queries and connManager
- Add all four handlers to router.Config struct
Fixes panic errors:
- internal/handlers/collections.go:78 (CreateCollection nil pointer)
- internal/handlers/media.go:891 (CreateMediaItem nil pointer)
Tests now pass:
- TestCollectionsBulkOperations: PASS
- TestAnalytics*: PASS (all analytics tests)
Note: Bruno API tests and frontend were NOT affected as they use the
real running application (which has complete handler setup).
325 lines
9.9 KiB
Go
325 lines
9.9 KiB
Go
package main
|
|
|
|
import (
|
|
"bookhoard/internal/config"
|
|
"bookhoard/internal/database"
|
|
"bookhoard/internal/handlers"
|
|
"bookhoard/internal/middleware"
|
|
ratelimit "bookhoard/internal/middleware"
|
|
"bookhoard/internal/router"
|
|
"bookhoard/internal/services"
|
|
"bookhoard/internal/sync"
|
|
"bytes"
|
|
"context"
|
|
"encoding/json"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/go-playground/validator/v10"
|
|
"github.com/google/uuid"
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/jackc/pgx/v5/pgxpool"
|
|
"github.com/labstack/echo/v4"
|
|
echomiddleware "github.com/labstack/echo/v4/middleware"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
// CustomValidator wraps the go-playground validator
|
|
type CustomValidator struct {
|
|
validator *validator.Validate
|
|
}
|
|
|
|
func (cv *CustomValidator) Validate(i interface{}) error {
|
|
return cv.validator.Struct(i)
|
|
}
|
|
|
|
// Helper functions for testing
|
|
func containsPrefix(s, prefix string) bool {
|
|
return len(s) >= len(prefix) && s[:len(prefix)] == prefix
|
|
}
|
|
|
|
func contains(s, substr string) bool {
|
|
return strings.Contains(s, substr)
|
|
}
|
|
|
|
func trimSpace(s string) string {
|
|
return strings.TrimSpace(s)
|
|
}
|
|
|
|
// isRunningInContainer detects if tests are running inside a Docker container
|
|
func isRunningInContainer() bool {
|
|
// Check for container-specific marker file
|
|
if _, err := os.Stat("/.dockerenv"); err == nil {
|
|
return true
|
|
}
|
|
|
|
// Check if /app/uploads exists (container path)
|
|
if _, err := os.Stat("/app/uploads"); err == nil {
|
|
return true
|
|
}
|
|
|
|
// Check environment variable (explicit override)
|
|
if os.Getenv("TEST_IN_CONTAINER") == "true" {
|
|
return true
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
// getUploadPath returns the appropriate upload path based on runtime environment
|
|
func getUploadPath() string {
|
|
// Check for explicit override first
|
|
if path := os.Getenv("TEST_UPLOAD_PATH"); path != "" {
|
|
return path
|
|
}
|
|
|
|
if isRunningInContainer() {
|
|
return "/app/uploads" // Container path (right side of volume mount)
|
|
}
|
|
|
|
return "./uploads" // Host path (left side of volume mount)
|
|
}
|
|
|
|
// getCachePath returns the appropriate cache path based on runtime environment
|
|
func getCachePath() string {
|
|
// Check for explicit override first
|
|
if path := os.Getenv("TEST_CACHE_PATH"); path != "" {
|
|
return path
|
|
}
|
|
|
|
if isRunningInContainer() {
|
|
return "/app/cache/kepub" // Container path (volume mount)
|
|
}
|
|
|
|
// Note: This is a Docker volume on host, not a folder
|
|
// Tests using this should handle the volume appropriately
|
|
return "/app/cache/kepub"
|
|
}
|
|
|
|
// setupTestServer creates a test server with a test database
|
|
// Returns: (*httptest.Server, *database.Queries, *config.Config)
|
|
func setupTestServer(t *testing.T) (*httptest.Server, *database.Queries, *config.Config) {
|
|
// Load configuration using the same method as main application
|
|
cfg := config.LoadConfig()
|
|
|
|
// Apply test-specific overrides
|
|
cfg.ServerPort = "0" // Use random port for tests
|
|
cfg.BaseURL = "http://localhost"
|
|
cfg.JWTSecret = "test-secret-key"
|
|
cfg.UploadPath = getUploadPath()
|
|
cfg.TestMode = true
|
|
cfg.RateLimitEnabled = false
|
|
cfg.RequestsPerMinute = 1000
|
|
|
|
// Connect to test database using the same method as main application
|
|
dbPool, err := pgxpool.New(context.Background(), cfg.DatabaseURL())
|
|
require.NoError(t, err, "Failed to connect to test database")
|
|
|
|
queries := database.New(dbPool)
|
|
|
|
// Create login attempt tracker
|
|
loginAttemptTracker := ratelimit.NewLoginAttemptTracker(5, 15*time.Minute, 5*time.Minute)
|
|
|
|
// Create handlers
|
|
authHandler := handlers.NewAuthHandler(queries, cfg.JWTSecret, loginAttemptTracker)
|
|
libraryHandler := handlers.NewLibraryHandler(queries)
|
|
deviceHandler := handlers.NewDeviceHandler(queries, cfg.JWTSecret, cfg)
|
|
deviceAuthMiddleware := middleware.NewDeviceAuthMiddleware(queries)
|
|
|
|
// Create WebSocket connection manager
|
|
connManager := sync.NewConnectionManager()
|
|
connManager.StartCleanupTask()
|
|
|
|
// Create sync queue processor
|
|
queueProcessor := sync.NewSyncQueueProcessor(queries)
|
|
go queueProcessor.Start(context.Background())
|
|
|
|
koreaderHandler := handlers.NewKOReaderHandler(queries, connManager, queueProcessor)
|
|
wsHandler := handlers.NewWSHandler(queries, connManager, cfg.JWTSecret, deviceAuthMiddleware)
|
|
conflictHandler := handlers.NewConflictHandler(queries, connManager)
|
|
analyticsHandler := handlers.NewAnalyticsHandler(queries)
|
|
queueHandler := handlers.NewQueueHandler(queries, queueProcessor)
|
|
|
|
// Create refactored handlers (matching main.go Phase 6)
|
|
worker := services.NewWorker(3)
|
|
collectionHandler := handlers.NewCollectionHandler(queries, connManager)
|
|
mediaHandler := handlers.NewMediaHandler(queries, worker)
|
|
searchHandler := handlers.NewSearchHandler(queries)
|
|
matchingHandler := handlers.NewMatchingHandler(queries, connManager)
|
|
|
|
// Create conversion service for OPDS
|
|
conversionService := services.NewConversionService(queries, getCachePath())
|
|
opdsHandler := handlers.NewOPDSHandler(queries, conversionService)
|
|
|
|
// Create Echo instance
|
|
e := echo.New()
|
|
|
|
// Set up validator
|
|
v := validator.New()
|
|
if err := ratelimit.RegisterPasswordValidation(v); err != nil {
|
|
t.Fatal("Failed to register password validator:", err)
|
|
}
|
|
e.Validator = &CustomValidator{validator: v}
|
|
|
|
// Middleware
|
|
e.Use(echomiddleware.Logger())
|
|
e.Use(echomiddleware.Recover())
|
|
e.Use(echomiddleware.CORS())
|
|
|
|
// Setup routes using router package
|
|
routerConfig := &router.Config{
|
|
Echo: e,
|
|
Queries: queries,
|
|
Cfg: cfg,
|
|
DBPool: dbPool,
|
|
AuthHandler: authHandler,
|
|
LibraryHandler: libraryHandler,
|
|
DeviceHandler: deviceHandler,
|
|
MediaHandler: mediaHandler,
|
|
SearchHandler: searchHandler,
|
|
MatchingHandler: matchingHandler,
|
|
KOReaderHandler: koreaderHandler,
|
|
WSHandler: wsHandler,
|
|
ConflictHandler: conflictHandler,
|
|
AnalyticsHandler: analyticsHandler,
|
|
QueueHandler: queueHandler,
|
|
CollectionHandler: collectionHandler,
|
|
OPDSHandler: opdsHandler,
|
|
ConnManager: connManager,
|
|
QueueProcessor: queueProcessor,
|
|
DeviceAuthMiddleware: deviceAuthMiddleware,
|
|
LoginTracker: loginAttemptTracker,
|
|
}
|
|
|
|
router.RegisterRoutes(routerConfig)
|
|
|
|
// Create test server
|
|
ts := httptest.NewServer(e)
|
|
|
|
// Return server, queries, and config
|
|
return ts, queries, cfg
|
|
}
|
|
|
|
// loginTestUser logs in a test user and returns the JWT token
|
|
func loginTestUser(t *testing.T, ts *httptest.Server, db *database.Queries) string {
|
|
// Ensure test user exists first
|
|
_ = getTestUserID(t, db)
|
|
|
|
loginRequest := map[string]interface{}{
|
|
"login": "testuser@example.com",
|
|
"password": "Test@Pass123!",
|
|
}
|
|
body, _ := json.Marshal(loginRequest)
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/api/auth/login", bytes.NewBuffer(body))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
|
|
client := &http.Client{}
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err, "Failed to login test user")
|
|
defer resp.Body.Close()
|
|
|
|
require.Equal(t, http.StatusOK, resp.StatusCode, "Login should succeed")
|
|
|
|
var result map[string]interface{}
|
|
json.NewDecoder(resp.Body).Decode(&result)
|
|
|
|
token, ok := result["access_token"].(string)
|
|
require.True(t, ok, "Should have access_token")
|
|
require.NotEmpty(t, token, "Access token should not be empty")
|
|
|
|
return token
|
|
}
|
|
|
|
func getTestUserID(t *testing.T, db *database.Queries) uuid.UUID {
|
|
ctx := context.Background()
|
|
|
|
// Check if test user exists and delete them first to ensure fresh state
|
|
user, err := db.GetUserByEmail(ctx, "testuser@example.com")
|
|
if err == nil {
|
|
// User exists, delete them to ensure fresh password
|
|
err = db.DeleteUser(ctx, user.ID)
|
|
if err != nil {
|
|
// If delete fails (user might be referenced elsewhere), log and continue
|
|
t.Logf("Warning: Could not delete existing test user: %v", err)
|
|
}
|
|
}
|
|
|
|
// Create a fresh test user with a valid password
|
|
// Password: "Test@Pass123!" meets complexity requirements
|
|
// This is the bcrypt hash for "Test@Pass123!"
|
|
passwordHash := "$2a$10$JjAtK7PPa1WexQC3AUGe8OXLeuseZ/haN1Mz7emMo6CfOvMiTVXWq"
|
|
|
|
newUser, err := db.CreateUser(ctx, database.CreateUserParams{
|
|
Email: "testuser@example.com",
|
|
Username: "testuser",
|
|
PasswordHash: passwordHash,
|
|
FirstName: pgtype.Text{String: "Test", Valid: true},
|
|
LastName: pgtype.Text{String: "User", Valid: true},
|
|
Role: "admin",
|
|
})
|
|
require.NoError(t, err, "Failed to create test user")
|
|
|
|
userUUID, err := uuid.FromBytes(newUser.ID.Bytes[:])
|
|
require.NoError(t, err, "Failed to parse user UUID")
|
|
return userUUID
|
|
}
|
|
|
|
// createTestEbookID creates a test ebook and returns its ID
|
|
func createTestEbookID(t *testing.T, ts *httptest.Server, token string) string {
|
|
// First create a library
|
|
libReq := map[string]interface{}{
|
|
"name": "Test Library",
|
|
"description": "A test library for ebooks",
|
|
"type": "ebooks",
|
|
}
|
|
libBody, _ := json.Marshal(libReq)
|
|
|
|
req, _ := http.NewRequest("POST", ts.URL+"/api/libraries", bytes.NewBuffer(libBody))
|
|
req.Header.Set("Content-Type", "application/json")
|
|
req.Header.Set("Authorization", "Bearer "+token)
|
|
|
|
client := &http.Client{}
|
|
resp, err := client.Do(req)
|
|
require.NoError(t, err)
|
|
defer resp.Body.Close()
|
|
|
|
require.Equal(t, http.StatusCreated, resp.StatusCode)
|
|
|
|
var libResult map[string]interface{}
|
|
json.NewDecoder(resp.Body).Decode(&libResult)
|
|
|
|
libData := libResult["id"].(string)
|
|
|
|
// Create a test ebook
|
|
ebookReq := map[string]interface{}{
|
|
"library_id": libData,
|
|
"title": "Test Ebook",
|
|
"author": "Test Author",
|
|
"file_path": "/tmp/test.epub",
|
|
"file_size": 1024,
|
|
"mime_type": "application/epub+zip",
|
|
}
|
|
ebookBody, _ := json.Marshal(ebookReq)
|
|
|
|
req2, _ := http.NewRequest("POST", ts.URL+"/api/media-items", bytes.NewBuffer(ebookBody))
|
|
req2.Header.Set("Content-Type", "application/json")
|
|
req2.Header.Set("Authorization", "Bearer "+token)
|
|
|
|
resp2, err := client.Do(req2)
|
|
require.NoError(t, err)
|
|
defer resp2.Body.Close()
|
|
|
|
require.Equal(t, http.StatusCreated, resp2.StatusCode)
|
|
|
|
var ebookResult map[string]interface{}
|
|
json.NewDecoder(resp2.Body).Decode(&ebookResult)
|
|
|
|
ebookID := ebookResult["id"].(string)
|
|
return ebookID
|
|
}
|