Bookhoard/foliate-js
1
0
Fork 0
mirror of https://github.com/john-okeefe/foliate-js.git synced 2026-09-09 11:29:14 -04:00
Code Issues Packages Projects Releases Wiki Activity

Don't check document's existence when expanding

Browse Source 
`expand()` is only called after `render()`, which assumes that it exists
This commit is contained in:
John Factotum
2024-03-21 20:22:31 +08:00
parent b0a869b7ed
commit 18159a4d07
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
paginator.js
+4 -5
View File
@@ -308,11 +308,12 @@ class View {
} }
} }
expand() { expand() {
const { documentElement } = this.document
if (this.#column) { if (this.#column) {
const side = this.#vertical ? 'height' : 'width' const side = this.#vertical ? 'height' : 'width'
const otherSide = this.#vertical ? 'width' : 'height' const otherSide = this.#vertical ? 'width' : 'height'
const contentRect = this.#contentRange.getBoundingClientRect() const contentRect = this.#contentRange.getBoundingClientRect()
const rootRect = this.document.documentElement.getBoundingClientRect() const rootRect = documentElement.getBoundingClientRect()
// offset caused by column break at the start of the page // offset caused by column break at the start of the page
// which seem to be supported only by WebKit and only for horizontal writing // which seem to be supported only by WebKit and only for horizontal writing
const contentStart = this.#vertical ? 0 const contentStart = this.#vertical ? 0
@@ -325,8 +326,7 @@ class View {
this.#element.style[side] = `${expandedSize + this.#size * 2}px` this.#element.style[side] = `${expandedSize + this.#size * 2}px`
this.#iframe.style[otherSide] = '100%' this.#iframe.style[otherSide] = '100%'
this.#element.style[otherSide] = '100%' this.#element.style[otherSide] = '100%'
if (this.document) documentElement.style[side] = `${this.#size}px`
this.document.documentElement.style[side] = `${this.#size}px`
if (this.#overlayer) { if (this.#overlayer) {
this.#overlayer.element.style.margin = '0' this.#overlayer.element.style.margin = '0'
this.#overlayer.element.style.left = this.#vertical ? '0' : `${this.#size}px` this.#overlayer.element.style.left = this.#vertical ? '0' : `${this.#size}px`
@@ -337,8 +337,7 @@ class View {
} else { } else {
const side = this.#vertical ? 'width' : 'height' const side = this.#vertical ? 'width' : 'height'
const otherSide = this.#vertical ? 'height' : 'width' const otherSide = this.#vertical ? 'height' : 'width'
const doc = this.document const contentSize = documentElement.getBoundingClientRect()[side]
const contentSize = doc?.documentElement?.getBoundingClientRect()?.[side]
const expandedSize = contentSize const expandedSize = contentSize
const { margin } = this.#layout const { margin } = this.#layout
const padding = this.#vertical ? `0 ${margin}px` : `${margin}px 0` const padding = this.#vertical ? `0 ${margin}px` : `${margin}px 0`