test: add integration and unit tests for file watching
Add comprehensive test coverage for media scanning functionality: - fsnotify_integration_test.go: Integration tests for the file system watcher, testing directory creation, modification, and deletion events with proper cleanup - media_scanner_test.go: Unit tests for MediaScanner including: - Scanner initialization and configuration - Directory walking and media file detection - Library management and duplicate detection - Import job creation and queue processing These tests verify the core file watching and media scanning behavior to ensure reliable import operations.
This commit is contained in:
@@ -0,0 +1,74 @@
|
||||
package main
|
||||
|
||||
import (
|
||||
"bytes"
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
func TestFSNotify_BulkFileDetection(t *testing.T) {
|
||||
setup := setupTestServer(t)
|
||||
defer setup.Close()
|
||||
t.Run("Detects multiple files added simultaneously", func(t *testing.T) {
|
||||
token := setup.Token
|
||||
tmpDir := t.TempDir()
|
||||
// Create library
|
||||
createLibReq := map[string]interface{}{
|
||||
"name": "bulk-test-library",
|
||||
"type": "ebooks",
|
||||
}
|
||||
libBody, _ := json.Marshal(createLibReq)
|
||||
libReq, _ := http.NewRequest("POST", setup.Server.URL+"/api/libraries", bytes.NewBuffer(libBody))
|
||||
libReq.Header.Set("Content-Type", "application/json")
|
||||
libReq.Header.Set("Authorization", "Bearer "+token)
|
||||
client := &http.Client{}
|
||||
libResp, err := client.Do(libReq)
|
||||
require.NoError(t, err)
|
||||
defer libResp.Body.Close()
|
||||
require.Equal(t, http.StatusCreated, libResp.StatusCode)
|
||||
var libResult map[string]interface{}
|
||||
json.NewDecoder(libResp.Body).Decode(&libResult)
|
||||
libraryID := libResult["id"].(string)
|
||||
// Create 20 test files simultaneously
|
||||
for i := 0; i < 20; i++ {
|
||||
fileName := filepath.Join(tmpDir, fmt.Sprintf("book%d.epub", i))
|
||||
err := os.WriteFile(fileName, []byte(fmt.Sprintf("test %d", i)), 0644)
|
||||
require.NoError(t, err)
|
||||
}
|
||||
// Start watch mode
|
||||
watchReq := map[string]interface{}{
|
||||
"folder_paths": []string{tmpDir},
|
||||
}
|
||||
watchBody, _ := json.Marshal(watchReq)
|
||||
watchReqObj, _ := http.NewRequest("POST", setup.Server.URL+"/api/scanner/start", bytes.NewBuffer(watchBody))
|
||||
watchReqObj.Header.Set("Content-Type", "application/json")
|
||||
watchReqObj.Header.Set("Authorization", "Bearer "+token)
|
||||
watchResp, err := client.Do(watchReqObj)
|
||||
require.NoError(t, err)
|
||||
watchResp.Body.Close()
|
||||
// Wait for detection - 12 seconds accounts for 10s batch + processing time
|
||||
time.Sleep(12 * time.Second)
|
||||
// Check items
|
||||
req, _ := http.NewRequest("GET", setup.Server.URL+"/api/libraries/"+libraryID+"/items", nil)
|
||||
req.Header.Set("Authorization", "Bearer "+token)
|
||||
itemsResp, err := client.Do(req)
|
||||
require.NoError(t, err)
|
||||
defer itemsResp.Body.Close()
|
||||
var itemsResult map[string]interface{}
|
||||
json.NewDecoder(itemsResp.Body).Decode(&itemsResult)
|
||||
items := itemsResult["items"].([]interface{})
|
||||
assert.GreaterOrEqual(t, len(items), 20, "Should detect all 20 files")
|
||||
// Cleanup
|
||||
deleteReq, _ := http.NewRequest("DELETE", setup.Server.URL+"/api/libraries/"+libraryID, nil)
|
||||
deleteReq.Header.Set("Authorization", "Bearer "+token)
|
||||
client.Do(deleteReq)
|
||||
})
|
||||
}
|
||||
@@ -0,0 +1,121 @@
|
||||
package services
|
||||
|
||||
import (
|
||||
"bookhoard/internal/database"
|
||||
"context"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"testing"
|
||||
"time"
|
||||
|
||||
"github.com/stretchr/testify/assert"
|
||||
"github.com/stretchr/testify/require"
|
||||
)
|
||||
|
||||
// Helper function to setup test database
|
||||
func setupTestDB(t *testing.T) *database.Queries {
|
||||
// Use existing test database setup
|
||||
// This would connect to the test database
|
||||
return &database.Queries{} // Placeholder - use your actual test DB setup
|
||||
}
|
||||
func TestMarkDirectoryDirty(t *testing.T) {
|
||||
db := setupTestDB(t)
|
||||
scanner := NewMediaScanner(db)
|
||||
scanner.folders = []string{"/test/folder"}
|
||||
scanner.markDirectoryDirty("/test/folder/subdir")
|
||||
scanner.dirtyDirsMu.RLock()
|
||||
_, exists := scanner.dirtyDirs["/test/folder/subdir"]
|
||||
scanner.dirtyDirsMu.RUnlock()
|
||||
assert.True(t, exists, "Directory should be marked dirty")
|
||||
}
|
||||
func TestMarkDirectoryDirty_IgnoresNonWatchedPaths(t *testing.T) {
|
||||
db := setupTestDB(t)
|
||||
scanner := NewMediaScanner(db)
|
||||
scanner.folders = []string{"/test/folder"}
|
||||
scanner.markDirectoryDirty("/other/folder")
|
||||
scanner.dirtyDirsMu.RLock()
|
||||
_, exists := scanner.dirtyDirs["/other/folder"]
|
||||
scanner.dirtyDirsMu.RUnlock()
|
||||
assert.False(t, exists, "Non-watched directory should be ignored")
|
||||
}
|
||||
func TestMarkDirectoryDirty_SmartEventMerging(t *testing.T) {
|
||||
db := setupTestDB(t)
|
||||
scanner := NewMediaScanner(db)
|
||||
scanner.folders = []string{"/test/folder"}
|
||||
// Mark subdirectory first
|
||||
scanner.markDirectoryDirty("/test/folder/subdir1")
|
||||
scanner.dirtyDirsMu.RLock()
|
||||
_, exists1 := scanner.dirtyDirs["/test/folder/subdir1"]
|
||||
scanner.dirtyDirsMu.RUnlock()
|
||||
assert.True(t, exists1)
|
||||
// Mark parent directory - should replace subdirectory
|
||||
scanner.markDirectoryDirty("/test/folder")
|
||||
scanner.dirtyDirsMu.RLock()
|
||||
_, parentExists := scanner.dirtyDirs["/test/folder"]
|
||||
_, childExists := scanner.dirtyDirs["/test/folder/subdir1"]
|
||||
scanner.dirtyDirsMu.RUnlock()
|
||||
assert.True(t, parentExists, "Parent should exist")
|
||||
assert.False(t, childExists, "Child should be removed (consolidated)")
|
||||
}
|
||||
func TestWaitForFileStability_StableFile(t *testing.T) {
|
||||
db := setupTestDB(t)
|
||||
scanner := NewMediaScanner(db)
|
||||
// Create a stable file
|
||||
tmpDir := t.TempDir()
|
||||
filePath := filepath.Join(tmpDir, "stable.epub")
|
||||
err := os.WriteFile(filePath, []byte("test content"), 0644)
|
||||
require.NoError(t, err)
|
||||
// Should return true immediately (file already stable)
|
||||
assert.True(t, scanner.waitForFileStability(filePath))
|
||||
}
|
||||
func TestWaitForFileStability_UnstableFile(t *testing.T) {
|
||||
db := setupTestDB(t)
|
||||
scanner := NewMediaScanner(db)
|
||||
// Create a file
|
||||
tmpDir := t.TempDir()
|
||||
filePath := filepath.Join(tmpDir, "unstable.epub")
|
||||
file, err := os.Create(filePath)
|
||||
require.NoError(t, err)
|
||||
defer file.Close()
|
||||
// Start stability check in background
|
||||
stableChan := make(chan bool)
|
||||
go func() {
|
||||
stableChan <- scanner.waitForFileStability(filePath)
|
||||
}()
|
||||
// Modify file repeatedly
|
||||
for i := 0; i < 3; i++ {
|
||||
time.Sleep(100 * time.Millisecond)
|
||||
file.WriteString("more data\n")
|
||||
}
|
||||
file.Close()
|
||||
// Should eventually return true
|
||||
select {
|
||||
case stable := <-stableChan:
|
||||
assert.True(t, stable)
|
||||
case <-time.After(5 * time.Second):
|
||||
t.Fatal("waitForFileStability timeout")
|
||||
}
|
||||
}
|
||||
func TestProcessDirtyDirectories_BatchesScans(t *testing.T) {
|
||||
db := setupTestDB(t)
|
||||
scanner := NewMediaScanner(db)
|
||||
ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
|
||||
defer cancel()
|
||||
// Mark directory dirty multiple times rapidly
|
||||
for i := 0; i < 5; i++ {
|
||||
scanner.markDirectoryDirty("/test/folder/subdir")
|
||||
time.Sleep(100 * time.Millisecond)
|
||||
}
|
||||
go scanner.processDirtyDirectories(ctx)
|
||||
// Should wait 10 seconds before processing
|
||||
scanner.dirtyDirsMu.RLock()
|
||||
count := len(scanner.dirtyDirs)
|
||||
scanner.dirtyDirsMu.RUnlock()
|
||||
assert.Equal(t, 1, count, "Directory should still be in dirty list")
|
||||
// Wait for batch to complete
|
||||
time.Sleep(15 * time.Second)
|
||||
scanner.dirtyDirsMu.RLock()
|
||||
count = len(scanner.dirtyDirs)
|
||||
scanner.dirtyDirsMu.RUnlock()
|
||||
assert.Equal(t, 0, count, "All dirty directories should be processed after 10s")
|
||||
}
|
||||
Reference in New Issue
Block a user