John O'Keefe
188ae076ab
handlers textToString, router textToString, router getText, and utils normText were four copies of the same NULL-to-empty unwrap (99 call sites). One exported utils.PgTextString replaces them all; the private normText (comparison normalizer) stays but is now the odd one out. Harness fix found on the way: setupTestServer built a full wiring literal for route registration and then RETURNED a second, sparser literal that never copied AnnotationService — setup.AnnotationService was always nil on the struct every test receives. Nobody noticed until cross_library_move_test became the first caller (it previously used the now-retired plain CreateMediaHighlight query); it now exercises the real SaveHighlight path through the wired service.
112 lines
2.8 KiB
Go
112 lines
2.8 KiB
Go
package handlers
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"bookhoard/internal/database"
|
|
"bookhoard/internal/utils"
|
|
|
|
"github.com/jackc/pgx/v5/pgtype"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCompareValues_Equals(t *testing.T) {
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.compareValues("Science Fiction", "equals", "Science Fiction")
|
|
assert.True(t, result)
|
|
|
|
result = handler.compareValues("Science Fiction", "equals", "Fantasy")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestCompareValues_Contains(t *testing.T) {
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.compareValues("Isaac Asimov", "contains", "asimov")
|
|
assert.True(t, result)
|
|
|
|
result = handler.compareValues("Isaac Asimov", "contains", "clarke")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestCompareValues_GreaterThan(t *testing.T) {
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.compareValues("2021", "greater_than", "2000")
|
|
assert.True(t, result)
|
|
|
|
result = handler.compareValues("1999", "greater_than", "2000")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestCompareValues_NotEquals(t *testing.T) {
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.compareValues("Science Fiction", "not_equals", "Fantasy")
|
|
assert.True(t, result)
|
|
|
|
result = handler.compareValues("Science Fiction", "not_equals", "Science Fiction")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestEvaluateRule_Genre(t *testing.T) {
|
|
item := database.ListMediaItemsRow{
|
|
Genre: pgtype.Text{String: "Science Fiction", Valid: true},
|
|
}
|
|
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.evaluateRule(item, "genre", "equals", "Science Fiction")
|
|
assert.True(t, result)
|
|
|
|
result = handler.evaluateRule(item, "genre", "equals", "Fantasy")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestEvaluateRule_Author(t *testing.T) {
|
|
item := database.ListMediaItemsRow{
|
|
Author: pgtype.Text{String: "Isaac Asimov", Valid: true},
|
|
}
|
|
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.evaluateRule(item, "author", "contains", "asimov")
|
|
assert.True(t, result)
|
|
|
|
result = handler.evaluateRule(item, "author", "contains", "clarke")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestEvaluateRule_CopyrightYear(t *testing.T) {
|
|
item := database.ListMediaItemsRow{
|
|
CopyrightYear: pgtype.Int4{Int32: 2021, Valid: true},
|
|
}
|
|
|
|
handler := &CollectionHandler{}
|
|
|
|
result := handler.evaluateRule(item, "copyright_year", "greater_than", "2000")
|
|
assert.True(t, result)
|
|
|
|
result = handler.evaluateRule(item, "copyright_year", "less_than", "2000")
|
|
assert.False(t, result)
|
|
}
|
|
|
|
func TestTextToString(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
input pgtype.Text
|
|
expected string
|
|
}{
|
|
{"valid text", pgtype.Text{String: "hello", Valid: true}, "hello"},
|
|
{"null text", pgtype.Text{Valid: false}, ""},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
result := utils.PgTextString(tt.input)
|
|
assert.Equal(t, tt.expected, result)
|
|
})
|
|
}
|
|
}
|